Bug 381941 – net-analyzer/vnstat-1.11-r1 breaks ownership of /var/run

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Klemen Mihevc 2011-09-05 13:20:23 UTC]

New init script for vnstat 1.11-r1 breaks ownership of /var/run

This line is responsible:
checkpath -q -d -m 755 -o vnstat:vnstat $( dirname /var/run/vnstatd )

for some reason this line changes ownership of /var/run to vnstat:vnstat as well...


mih ~ # emerge --info
Portage 2.1.10.13 (default/linux/x86/10.0, gcc-4.5.3, glibc-2.13-r4, 3.0.4-gentoo i686)
=================================================================
System uname: Linux-3.0.4-gentoo-i686-Intel-R-_Pentium-R-_4_CPU_2.40GHz-with-gentoo-2.0.3
Timestamp of tree: Mon, 05 Sep 2011 08:15:01 +0000
app-shells/bash:          4.2_p10
dev-lang/python:          2.7.2-r2, 3.2-r2
dev-util/cmake:           2.8.5-r2
dev-util/pkgconfig:       0.26
sys-apps/baselayout:      2.0.3
sys-apps/openrc:          0.9.2
sys-apps/sandbox:         2.5
sys-devel/autoconf:       2.68
sys-devel/automake:       1.11.1-r1
sys-devel/binutils:       2.21.1-r1
sys-devel/gcc:            4.5.3-r1
sys-devel/gcc-config:     1.4.1-r1
sys-devel/libtool:        2.4-r1
sys-devel/make:           3.82-r1
sys-kernel/linux-headers: 2.6.39 (virtual/os-headers)
sys-libs/glibc:           2.13-r4
Repositories: gentoo LocalPortage
ACCEPT_KEYWORDS="x86 ~x86"
ACCEPT_LICENSE="*"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-march=pentium4 -mtune=pentium4 -O2 -pipe -fomit-frame-pointer -msse -msse2 -mmmx"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt /var/bind"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5.3/ext-active/ /etc/php/cgi-php5.3/ext-active/ /etc/php/cli-php5.3/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-march=pentium4 -mtune=pentium4 -O2 -pipe -fomit-frame-pointer -msse -msse2 -mmmx"
DISTDIR="/usr/portage/distfiles"
FEATURES="assume-digests binpkg-logs distlocks ebuild-locks fixlafiles fixpackages news parallel-fetch protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch"
FFLAGS=""
GENTOO_MIRRORS="ftp://mirror.netcologne.de/gentoo/ ftp://ftp.uni-erlangen.de/pub/mirrors/gentoo ftp://gentoo.lagis.at/"
LANG="en_US.UTF8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--sort-common"
LINGUAS="en sl"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="-6 --recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude='/distfiles' --exclude='/local' --exclude='/packages'"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.de.gentoo.org/gentoo-portage"
USE="acl acpi animgif apache2 apm apng authfile bash-completion berkdb bluetooth bzip2 caps ccache cgi cli client cracklib crypt cups curl cxx dbus dedicated dhcp dovecot-sasl dri eap-tls encode exif expat extras fontconfig fortran ftp gd gdbm geoip gif gmp gpg gpm gzip hardened iconv icu idn imap intl ipv6 ithreads jpeg lcms ldap lua lzma lzo maildir mhash mmx mng modules mpi mudflap mysql mysqli ncurses netboot nls nptl nptlonly ntp ocaml ocamlopt odbc openmp pam pbxt pch pcntl pcre pdo perl phar php pic png pop3d posix pppd python quota raw readline rpc ruby samba sasl server session slang smtp snmp soap sockets socks5 spell sse sse2 ssl suexec suhosin svg swig sysfs tcl tcpd threads tiff truetype udev unicode urandom usb vhosts x86 xinetd xml xmlreader xmlrpc xmlwriter xsl xtradb zip zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1 emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias auth_digest authn_dbd ident proxy proxy_ajp proxy_balancer proxy_connect proxy_ftp proxy_http proxy_scgi" APACHE2_MPMS="event" CALLIGRA_FEATURES="kexi words flow plan stage tables krita karbon braindump" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog apache bind logfile mysql network ntpd tcpconns uptime" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="en sl" PHP_TARGETS="php5-3" RUBY_TARGETS="ruby18" USERLAND="GNU" VIDEO_CARDS="fbdev glint intel mach64 mga neomagic nouveau nv r128 radeon savage sis tdfx trident vesa via vmware dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

[Comment 1 Jason Short 2011-10-02 15:16:40 UTC]

calling `dirname` on '/var/run/vnstat' of course results in '/var/run', which checkpath then happily chowns for us.  this is of course not a good idea.

either remove the dirname, modify the arg to '/var/run/vnstatd/vnstatd.pid', or try to grep PidFile config line from the --config parameter.

[Comment 2 Michael Palimaka (kensington) 2011-11-17 17:26:57 UTC]

This has since been fixed: http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/net-analyzer/vnstat/files/vnstatd.initd?r1=1.3&r2=1.4

[Comment 3 Peter Volkov (RETIRED) 2011-12-17 02:14:52 UTC]

Thank you guys. Closing as is fixed.