Bug 381853 – app-portage/layman-2.0.0_rc2: Error was: error() takes exactly 2 arguments (3 given)

• Product: Portage Development
• Status: RESOLVED FIXED

[Description Dennis Schridde 2011-09-05 06:00:40 UTC]

After apparently successfully running a sync, eix-sync aborts with one error message per git repository: error() takes exactly 2 arguments (3 given), saying that layman -S failed.

I have the following in layman.cfg:
git_postsync : GIT_DIR=%cwd= git-set-file-times

Reproducible: Always




 * Syncing selected overlays,...
 * Running Git... # ( cd /var/cache/portage/layman/kde  && /usr/bin/git pull )
Already up-to-date.
 * 
 * Succeeded:
 * ------
 * Successfully synchronized overlay "sunrise".
 * 
 * 
 * Errors:
 * ------
 * Failed to sync overlay "kde".
 * Error was: error() takes exactly 2 arguments (3 given)
 * 

 * CLI: Errors occured processing action sync_all
 * 
 * Errors:
 * ------
 * Failed to sync overlay "kde".
 * Error was: error() takes exactly 2 arguments (3 given)
 * 

 * layman -S failed

[Comment 1 Dennis Schridde 2011-09-05 06:02:21 UTC]

Prepending "env" to the git_postsync command makes the error go away, hence I assume that the command failed before and layman had trouble creating an appropriate error message.

[Comment 2 Brian Dolbec (RETIRED) 2011-09-05 16:17:14 UTC]

Thank you.  fixed in vcs commit: 6566ed3969a81d5d54cc17d9ec15ccef31ab9000

I had mistakenly added a noise level parameter to the two error messages it was suppose to output when the child process failed for whatever reason.  So yes, layman was having trouble reporting the error, my fault.

You can get the fix in layman-9999 now.  9999 is in bugfix only mode till the 2.0.0 final release.  There have been a few, so perhaps is time for rc3.

[Comment 3 Brian Dolbec (RETIRED) 2011-12-03 00:43:55 UTC]

Fix is released in >=layman-2.0.0_rc3.