Bug 379115 – dev-libs/glib-2.28.8 should ALWAYS punt .la files as it ships proper pkg-config files(was: should not punt .la files when USE=static-libs)

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Alexandre Rostovtsev (RETIRED) 2011-08-14 01:36:36 UTC]

Created attachment 283257 [details, diff]
patch for glib-2.28.8.ebuild

Three days ago, Samuli modified the dev-libs/glib-2.28.8 ebuild to unconditionally remove .la files in src_install; see http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/dev-libs/glib/glib-2.28.8.ebuild?r1=1.10&r2=1.11

However, glib has a static-libs USE flag, and when it's enabled (and it is enabled by default), glib will install static libraries. If a package installs static libraries, then, unless I am entirely mistaken, it should also install .la files to allow static linking using libtool.

I believe that the ebuild should be changed to only punt .la files when USE=-static-libs. My proposed patch is attached.

[Comment 1 Nirbheek Chauhan (RETIRED) 2011-08-14 03:04:17 UTC]

I'm thinking we should also not do IUSE=+static-libs. But we should probably do that in the ~arch tree, with 2.29/30 perhaps. There's unknown breakage without IUSE=+static-libs.

[Comment 2 Nirbheek Chauhan (RETIRED) 2011-08-14 03:08:21 UTC]

Alrighty, fixed. Thanks for reporting!

[Comment 3 Samuli Suominen (RETIRED) 2011-08-14 09:34:45 UTC]

reopneing as the first commit was correct, and glib-2.0 has proper pkg-config files making all .la files redudant in any case

please revert

[Comment 4 Samuli Suominen (RETIRED) 2011-08-14 09:44:11 UTC]

+  14 Aug 2011; Samuli Suominen <[e-mail]> glib-2.28.8.ebuild:
+  Revert last libtool file preservation since we have usable pkg-config files
+  wrt #379115.