Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 37899

Summary: app-i18n/koffice-i18n-1.2.1-r1 is broken
Product: Gentoo Linux Reporter: Marius Mauch (RETIRED) <genone>
Component: [OLD] KDEAssignee: Michele Balistreri (RETIRED) <brain>
Status: RESOLVED FIXED    
Severity: normal CC: kde
Priority: High    
Version: unspecified   
Hardware: All   
OS: All   
Whiteboard:
Package list:
Runtime testing required: ---

Description Marius Mauch (RETIRED) gentoo-dev 2004-01-11 10:39:54 UTC
a) you should not set SRC_URI dynamically
b) code that might print stuff to stdout or stderr should under no circumstances be outside of functions
c) "if [ `use foo` ]; then" should not be used, please use "if use foo; then"

while it might work as it is right now it might break without notice and is generally considered bad practice.
Comment 1 Heinrich Wendel (RETIRED) gentoo-dev 2004-03-09 07:15:41 UTC
this has all been fixed in 1.3