Summary: | media-gfx/brlcad fails to build with libpng-1.5 (missing zlib.h include) | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Diego Elio Pettenò (RETIRED) <flameeyes> |
Component: | New packages | Assignee: | Dongxu Li <dongxuli2011> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | dilfridge, sci |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 354479 | ||
Attachments: |
Build log
complete fix for libpng-1.5 support |
Description
Diego Elio Pettenò (RETIRED)
2011-08-08 10:52:40 UTC
already fixed by upstream in subversion trunk. A patch for 7.20.2 version is included in science overlay, hopefully, pushed to main tree soon. Thanks for reporting. Has to be open until in main tree. brlcad needs tkimg, and tkimg maintainers have taken poor stance at bug 378261, so this wasn't really tested other than "it applies and should fix the error in the build.log" + 14 Sep 2011; Samuli Suominen <ssuominen@gentoo.org> brlcad-7.18.4.ebuild, + +files/brlcad-7.18.4-libpng15.patch: + Fix building with libpng15 (missing zlib.h include) wrt #378273 by Diego Elio + Pettenò please reopen if it still doesn't build Not fixed -- there's another zlib error: src/fb/fb-png.c:188: error: ‘Z_BEST_COMPRESSION’ undeclared (first use in this function) ..and also src/util/pix-png.c has less trivial incompatibilities: In file included from pix-png.c:40: /usr/include/png.h:1728: error: expected declaration specifiers or ‘...’ before ‘png_FILE_p’ pix-png.c: In function ‘write_png’: pix-png.c:147: error: too many arguments to function ‘png_init_io’ ..i'll see if i can get a patch done this afternoon. or simply wait for 7.20.4 if it's too much trouble to backport the fixes Created attachment 287031 [details]
complete fix for libpng-1.5 support
This patch includes the previous one, and adds the patches for the remaining two files. Fortunately, both fixes were rather simple.
Ok so this can't be fixed unless bug #378261 is fixed. + 23 Sep 2011; Lars Wendler <polynomial-c@gentoo.org> + files/brlcad-7.18.4-libpng15.patch: + non-maintainer commit: Added fixed patch to build with libpng15 (bug + #378273). ACKed by ssuominen. Thanks to Ian Stakenvicius for providing a + working patch. + |