| Summary: | sys-fs/multipath-tools: should remove dependency on sys-fs/sysfsutils | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Anthony Basile <blueness> |
| Component: | Current packages | Assignee: | Gentoo's Team for Core System packages <base-system> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 377673 | ||
|
Description
Anthony Basile
2011-08-04 10:24:13 UTC
Yup, it was removed upstream long time ago: http://git.kernel.org/gitweb.cgi?p=linux/storage/multipath-tools/.git;a=commit;h=8ccef7c766a4891140488d12d93e5eb930271bf2 And I've checked sources. It's very safe to remove this dependency. (In reply to comment #1) > Yup, it was removed upstream long time ago: > > http://git.kernel.org/gitweb.cgi?p=linux/storage/multipath-tools/.git;a=commit;h=8ccef7c766a4891140488d12d93e5eb930271bf2 > > And I've checked sources. It's very safe to remove this dependency. That commit was on Thu, 7 Jun 2007 and all the current ebuilds are >= 2009 so, yeah, RDEPEND="... sys-fs/sysfsutils ... " is just cruft. Anyone from baselayout want to make the change? I can if you give me the okay. I propose changing it without rev bump. (In reply to comment #1) > Yup, it was removed upstream long time ago: > > http://git.kernel.org/gitweb.cgi?p=linux/storage/multipath-tools/.git;a=commit;h=8ccef7c766a4891140488d12d93e5eb930271bf2 > > And I've checked sources. It's very safe to remove this dependency. 0.4.7 source tree is still using it: $ egrep -r -e '^#include.*sysfs' * libmultipath/discovery.c:#include <sysfs/dlist.h> libmultipath/discovery.c:#include <sysfs/libsysfs.h> multipath/main.c:#include <sysfs/libsysfs.h> multipathd/main.c:#include <sysfs/libsysfs.h> multipathd/main.c:#include <sysfs/dlist.h> 0.4.8 and 0.4.9 use only internal libmultipath header called sysfs.h, not to be confused with sysfsutils: $ egrep -r -e '^#include.*sysfs' * multipath/main.c:#include <sysfs.h> multipathd/cli_handlers.c:#include <sysfs.h> multipathd/main.c:#include <sysfs.h> libmultipath/structs_vec.c:#include "sysfs.h" libmultipath/discovery.c:#include "sysfs.h" libmultipath/sysfs.c:#include "sysfs.h" $ egrep -r -e '^#include.*sysfs' * libmultipath/structs_vec.c:#include "sysfs.h" libmultipath/discovery.c:#include "sysfs.h" libmultipath/sysfs.c:#include "sysfs.h" multipath/main.c:#include <sysfs.h> multipathd/cli_handlers.c:#include <sysfs.h> multipathd/main.c:#include <sysfs.h> + 06 Aug 2011; Samuli Suominen <ssuominen@gentoo.org> + multipath-tools-0.4.8.ebuild, multipath-tools-0.4.8-r1.ebuild, + multipath-tools-0.4.9-r1.ebuild, multipath-tools-0.4.9-r2.ebuild: + Remove sys-fs/sysfsutils depend from >= 0.4.8 wrt #377709 by Anthony Basile and 0.4.7 stays as is |