Summary: | sys-apps/openrc: service_get_value strips \n and returns only one line | ||
---|---|---|---|
Product: | Gentoo Hosted Projects | Reporter: | Christian Ruppert (idl0r) <idl0r> |
Component: | OpenRC | Assignee: | OpenRC Team <openrc> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | robbat2 |
Priority: | Normal | Keywords: | InVCS |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 374183 | ||
Attachments: | rc_getline-rc_service_get_value.patch (DRAFT) |
Description
Christian Ruppert (idl0r)
2011-07-12 01:21:47 UTC
i dont think we should be changing rc_getline() semantics. since you basically want the contents of the file, add a new helper like "rc_getfile()" and use that. also, side notes: - xrealloc(NULL, 10) is the same as xmalloc(10), so you dont need two diff code paths there based on "value" - dont cast the return value of alloc funcs as they return (void*) This has been fixed by the new rc_getfile() function in commit fdaf1c65cdcba2d9b83e02cc0d08fb6dbbd80a80 http://git.overlays.gentoo.org/gitweb/?p=proj/openrc.git;a=commit;h=fdaf1c65 I am closing this since it was resolved a while back and it is listed on the tracker. |