Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 374723

Summary: app-misc/binwalk: bump to 0.3.7
Product: Gentoo Linux Reporter: Anthony Basile <blueness>
Component: Current packagesAssignee: Tim Harder <radhermit>
Status: RESOLVED FIXED    
Severity: enhancement    
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: Ebuild for the bump
Allows -jX to recurse into subshell's make
Improved patch for parallel builds

Description Anthony Basile gentoo-dev 2011-07-10 18:07:55 UTC
Created attachment 279669 [details]
Ebuild for the bump

I didn't know this was in the tree until after I wrote the ebuild (yeah, lame).  Anyhow, it wasn't a waste because I've been working with upstream and they just change the structure of their source and build system, so a revamp of the ebuild was needed.  I tested that CFLAGS and LDFLAGS are respected.  I also addressed a minor QA point regarding parallel builds, ie make -jX where X>1.

Finally, look a the DEPENDS, because I don't think binwalk depends on files anymore, and it might be a good idea to put an explicit depend on zlib.
Comment 1 Anthony Basile gentoo-dev 2011-07-10 18:10:18 UTC
Created attachment 279671 [details, diff]
Allows -jX to recurse into subshell's make
Comment 2 Anthony Basile gentoo-dev 2011-07-10 18:57:40 UTC
Created attachment 279673 [details, diff]
Improved patch for parallel builds

This is more along the lines of what the GNU Makefile standards suggest.  See

http://www.gnu.org/s/hello/manual/make/MAKE-Variable.html#MAKE-Variable
Comment 3 Tim Harder gentoo-dev 2011-07-11 04:38:33 UTC
These appear to be all new issues with the latest release (0.3.7) that hasn't been added yet since I patched many similar issues with upstream back around 0.3.2 or so when there wasn't an official autotools setup.

Also, binwalk still depends on file and imo does a worse job then previous releases since it appears to now bundle a tarball and build it internally instead of linking against the system library.
Comment 4 Tim Harder gentoo-dev 2011-07-20 04:20:52 UTC
Added to CVS along with a patch to use system libs for magic (sys-apps/file).