Summary: | sys-apps/openrc-0.8.2-r1: ignores entries in /etc/conf.d/modules w/o kernel version | ||
---|---|---|---|
Product: | Gentoo Hosted Projects | Reporter: | Toralf Förster <toralf> |
Component: | OpenRC | Assignee: | OpenRC Team <openrc> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | jlec |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 374183 | ||
Attachments: | log output |
Description
Toralf Förster
2011-07-02 12:43:33 UTC
if you have "modules_2_6", then "modules" wont be read for 2.6.x kernels. this is by design ... variables do not accumulate; only the most exact gets read. run `/etc/init.d/modules --debug start` and post the log as an attachment. Created attachment 278941 [details] log output (In reply to comment #1) > if you have "modules_2_6", then "modules" wont be read for 2.6.x kernels. this > is by design ... variables do not accumulate; only the most exact gets read. Ick, that explains it, ok then this should work for 2.6 and 3.x kernels : ? n22 ~ # grep -v '#' /etc/conf.d/modules | grep -v '^$' modules_2_6="${modules_2_6} acpi-cpufreq" module_acpi_cpufreq_args_2_6="" modules_3="${modules_3} acpi-cpufreq" module_acpi_cpufreq_args_3="" modules_2_6="${modules_2_6} fbcon" module_fbcon_args_2_6="" > run `/etc/init.d/modules --debug start` and post the log as an attachment. done BTW it is intended that for 2.6.39.2 and 2.6, but not for 2.6.39 is searched ? Ok, I found the bug, and have committed a fix in patch be990b30. In the old code, here's what happened: If your kernel version had 4 components (say 1.2.3.4), it would look only at the following variables: modules_1_2_3_4 modules_1_2 modules If you had 3 components, you get: modules_1_2_3 modules_1_2 modules Clearly this always missed modules_1 and iff KV component count was 4, then also modules_1_2_3. *** Bug 379667 has been marked as a duplicate of this bug. *** Does that commit also fix this issue : This does not work (all kernels <2.6.38 do not load fbcon automatically) : modules_2_6="acpi-cpufreq" modules_2_6_37="acpi-cpufreq fbcon" This works (but unfortunately fbcon is loaded >=2.6.38 kernels too) modules_2_6="acpi-cpufreq fbcon" ??? (In reply to comment #6) > Does that commit also fix this issue : > > This does not work (all kernels <2.6.38 do not load fbcon automatically) : > modules_2_6="acpi-cpufreq" > modules_2_6_37="acpi-cpufreq fbcon" > > This works (but unfortunately fbcon is loaded >=2.6.38 kernels too) > modules_2_6="acpi-cpufreq fbcon" > > ??? What are you actually trying to accomplish? The most specific matching variable is used to pick what modules to load. There is no support for version ranges. (In reply to comment #7) > The most specific matching variable is used to pick what modules to load. Well - if I boot kernel 2.6.37 I'd expect that this line matches, but it doesn't : modules_2_6_37="acpi-cpufreq fbcon" Furthermore this line isn't used for any booted kernel 3.x even if no other 3.x line is specified: modules_3="acpi-cpufreq" |