Bug 373579 – sys-kernel/genkernel-3.4.12.6-r2 no need separate blkid binary

• Product: Gentoo Hosted Projects
• Status: RESOLVED WONTFIX

[Description Alexander Zubkov 2011-06-30 11:36:49 UTC]

As I see sys-kernel/genkernel-3.4.12.6-r2 using busybox version 1.18.1. This version of busybox already have embedded blkid tool, which compiles by default. So there is no need in compiling separate blkid binary. Busybox will use its internal anyway.
Also, in one of genkernel bugs I noted that blkid embedded into busybox works better than separate. Because in my configuration with mdadm, separate blkid finds labels only after second run (don't know why) and embedded works as needed. So it is preferred for me, at least.

[Comment 1 Sebastian Pipping 2011-07-01 02:27:32 UTC]

(In reply to comment #0)
> As I see sys-kernel/genkernel-3.4.12.6-r2 using busybox version 1.18.1. This
> version of busybox already have embedded blkid tool, which compiles by default.
> So there is no need in compiling separate blkid binary. Busybox will use its
> internal anyway.

Depends.  Please check <https://bugs.gentoo.org/show_bug.cgi?id=352746#c3>


> Also, in one of genkernel bugs I noted that blkid embedded into busybox works
> better than separate. Because in my configuration with mdadm, separate blkid
> finds labels only after second run (don't know why) and embedded works as
> needed. So it is preferred for me, at least.

If there are problems with blkid of e2fsprogs we can bump that or fix genkernel's way to use it.  Reverting to busybox' internal copy is unlikely.  In any case please provide more information so we can reproduce and fix this.  Thanks!

[Comment 2 Alexander Zubkov 2011-07-01 07:48:01 UTC]

Hmm. Seems strange. I was changing genkernel-3.4.10.907 some time ago to make my system bootable. It begin to work after I upgraded genkernel's busybox to version 1.18.0. I thaught it was because of busybox blkid. But I see now that blkid is called in 3.4.10.907 and 3.4.12.6-r2 such a way, that embedded will not work. So the promblem is somewhere else. :) 
Also, I thaught that busybox will run embedded command if it is not passed full path to it (bash or sh doing so).
I'll try to reproduce my problem in sandbox and report it.

By the way (little offtopic). I see calls to blkid like this:

ROOT_DEV=`blkid -l -t "${REAL_ROOT}" | cut -d ":" -f 1 2>/dev/null`

I think this can be replaced by:

ROOT_DEV=`blkid -l -o device -t "${REAL_ROOT}"`

[Comment 3 Sebastian Pipping 2012-05-17 18:38:42 UTC]

Since genkernel 3.4.33, blkid of util-linux is used (and it will probably stay that way).  I am closing the bug as wontfix for now.


(In reply to comment #2)
> By the way (little offtopic). I see calls to blkid like this:
> 
> ROOT_DEV=`blkid -l -t "${REAL_ROOT}" | cut -d ":" -f 1 2>/dev/null`
> 
> I think this can be replaced by:
> 
> ROOT_DEV=`blkid -l -o device -t "${REAL_ROOT}"`

Thanks for that!