Bug 373193 – net-misc/l7-protocols-2008.12.18 tc-getCC bad replace

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Bertrand Jacquin 2011-06-27 11:45:25 UTC]

src_unpack for x86 stable l7-protocols use sed to replace "gcc" to "tc-getCC" and add CFLAGS and LDFLAGS. As CFLAGS often contain path (-I/usr/i586-geode-linux-gnu/usr/include/), sed faile as '/' is use as pattern separator :

Attached a simple fix to use ';' as pattern separator

>>> Emerging (1 of 1) net-misc/l7-protocols-2008.12.18 for /usr/i586-geode-linux-gnu/
 * l7-protocols-2008-12-18.tar.gz RMD160 SHA1 SHA256 size ;-) ...                                                                                    [ ok ]
 * Package:    net-misc/l7-protocols-2008.12.18
 * Repository: gentoo
 * Maintainer: [e-mail] [e-mail]
 * USE:        elibc_glibc kernel_linux userland_GNU x86
 * FEATURES:   sandbox
>>> Unpacking source...
>>> Unpacking l7-protocols-2008-12-18.tar.gz to /usr/i586-geode-linux-gnu/tmp/portage/net-misc/l7-protocols-2008.12.18/work
sed: -e expression #1, char 83: unknown option to `s'
 * Replacing obsolete head/tail with POSIX compliant ones
 *  - fixed testing/doallspeeds.sh
 *  - fixed testing/test_match.sh
 *  - fixed testing/timeit.sh
>>> Source unpacked in /usr/i586-geode-linux-gnu/tmp/portage/net-misc/l7-protocols-2008.12.18/work
>>> Compiling source in /usr/i586-geode-linux-gnu/tmp/portage/net-misc/l7-protocols-2008.12.18/work/l7-protocols-2008-12-18 ...

make -j1 -C testing 
make: Entering directory `/usr/i586-geode-linux-gnu/tmp/portage/net-misc/l7-protocols-2008.12.18/work/l7-protocols-2008-12-18/testing'
gcc -O2 -o randchars randchars.c
gcc -O2 -o randprintable randprintable.c
gcc -o test_speed-kernel test_speed-kernel.c
g++ -Wall -o test_speed-userspace test_speed-userspace.cpp l7-parse-patterns.cpp
gcc -O2 -o match_kernel match-kernel.c
make: Leaving directory `/usr/i586-geode-linux-gnu/tmp/portage/net-misc/l7-protocols-2008.12.18/work/l7-protocols-2008-12-18/testing'
>>> Source compiled.
>>> Test phase [not enabled]: net-misc/l7-protocols-2008.12.18
>>> Install l7-protocols-2008.12.18 into /usr/i586-geode-linux-gnu/tmp/portage/net-misc/l7-protocols-2008.12.18/image/ category net-misc


Exiting on signal 2
>>> Completed installing l7-protocols-2008.12.18 into /usr/i586-geode-linux-gnu/tmp/portage/net-misc/l7-protocols-2008.12.18/image/


* Wrong EM_TYPE. Expected EM_386
EM_X86_64 ./usr/share/l7-protocols/match_kernel
EM_X86_64 ./usr/share/l7-protocols/test_speed-userspace
EM_X86_64 ./usr/share/l7-protocols/test_speed-kernel
EM_X86_64 ./usr/share/l7-protocols/randchars
EM_X86_64 ./usr/share/l7-protocols/randprintable

Reproducible: Always

Steps to Reproduce:
1. i586-geode-linux-gnu-emerge -va1 net-misc/l7-protocols
2.
3.

[Comment 1 Bertrand Jacquin 2011-06-27 11:47:18 UTC]

Created attachment 278329 [details, diff]
l7-protocols-BJA-sed-use-sep.diff

[Comment 2 Justin Lecher (RETIRED) 2011-06-27 11:50:58 UTC]

Could you please post the output of emerge --info?

[Comment 3 Bertrand Jacquin 2011-06-27 12:28:07 UTC]

(In reply to comment #2)
> Could you please post the output of emerge --info?

# i586-geode-linux-gnu-emerge --info
Portage 2.1.10.3 (embedded, gcc-4.5.2, unavailable, 2.6.38-gentoo-r1 x86_64)
=================================================================
System uname: Linux-2.6.38-gentoo-r1-x86_64-Intel-R-_Core-TM-2_Quad_CPU_Q9650_@_3.00GHz-with-gentoo-2.0.3
Timestamp of tree: Sun, 26 Jun 2011 13:15:02 +0000
app-shells/bash:          4.2_p10
dev-lang/python:          2.7.1-r1, 3.2
dev-util/cmake:           2.8.4-r1
sys-apps/baselayout:      2.0.3
sys-apps/openrc:          0.8.3
sys-apps/sandbox:         2.5
sys-devel/autoconf:       2.68
sys-devel/automake:       1.9.6-r3, 1.11.1-r1
sys-devel/binutils:       2.21
sys-devel/gcc:            4.5.2
sys-devel/gcc-config:     1.4.1-r1
sys-devel/libtool:        2.4-r1
sys-devel/make:           3.82-r1
sys-kernel/linux-headers: 2.6.38 (virtual/os-headers)
sys-libs/glibc:           2.13-r2
Repositories: gentoo meleeweb
ACCEPT_KEYWORDS="x86"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-Os -pipe -march=k6-2 -fomit-frame-pointer -I/usr/i586-geode-linux-gnu/usr/include/ -I/usr/i586-geode-linux-gnu/include/"
CHOST="i586-geode-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt /usr/share/openvpn/easy-rsa"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5.3/ext-active/ /etc/php/cgi-php5.3/ext-active/ /etc/php/cli-php5.3/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-Os -pipe -march=k6-2 -fomit-frame-pointer -I/usr/i586-geode-linux-gnu/usr/include/ -I/usr/i586-geode-linux-gnu/include/"
DISTDIR="/usr/portage/distfiles"
FEATURES="assume-digests binpkg-logs buildpkg collision-protect distlocks ebuild-locks fixlafiles fixpackages nodoc noinfo noman parallel-fetch protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch"
FFLAGS=""
GENTOO_MIRRORS="http://mirror.meleeweb.net/pub/linux/gentoo http://ftp.free.fr/mirrors/ftp.gentoo.org"
LDFLAGS="-L/usr/i586-geode-linux-gnu/lib -L/usr/i586-geode-linux-gnu/usr/lib"
LINGUAS="en"
MAKEOPTS="-j1"
PKGDIR="/usr/i586-geode-linux-gnu/packages/"
PORTAGE_CONFIGROOT="/usr/i586-geode-linux-gnu/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/usr/i586-geode-linux-gnu/tmp/"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/opt/meleeweb/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="hardened kdrive make-symlinks minimal modules multicall x86 zlib" ELIBC="glibc" INPUT_DEVICES="evdev mouse keyboard tslib" KERNEL="linux" LINGUAS="en" USERLAND="GNU" VIDEO_CARDS="fbdev" 
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

[Comment 4 Justin Lecher (RETIRED) 2011-06-27 13:43:15 UTC]

> CFLAGS="-Os -pipe -march=k6-2 -fomit-frame-pointer
> -I/usr/i586-geode-linux-gnu/usr/include/ -I/usr/i586-geode-linux-gnu/include/"
> CHOST="i586-geode-linux-gnu"

Beside you are probably right with the sed, could you please explain, why you have those header paths in your CFLAGS? They yhould be handled internally like /usr/include and if you need to sed them, they should go to CPPFLAGS instead.

[Comment 5 Bertrand Jacquin 2011-06-27 14:00:08 UTC]

(In reply to comment #4)
> > CFLAGS="-Os -pipe -march=k6-2 -fomit-frame-pointer
> > -I/usr/i586-geode-linux-gnu/usr/include/ -I/usr/i586-geode-linux-gnu/include/"
> > CHOST="i586-geode-linux-gnu"
> 
> Beside you are probably right with the sed, could you please explain, why you
> have those header paths in your CFLAGS? They yhould be handled internally like
> /usr/include and if you need to sed them, they should go to CPPFLAGS instead.

This is a default behaviour in crossdev. May we CC spanky ?

[Comment 6 Justin Lecher (RETIRED) 2011-06-27 14:03:23 UTC]

(In reply to comment #5)
> (In reply to comment #4)
> > > CFLAGS="-Os -pipe -march=k6-2 -fomit-frame-pointer
> > > -I/usr/i586-geode-linux-gnu/usr/include/ -I/usr/i586-geode-linux-gnu/include/"
> > > CHOST="i586-geode-linux-gnu"
> > 
> > Beside you are probably right with the sed, could you please explain, why you
> > have those header paths in your CFLAGS? They yhould be handled internally like
> > /usr/include and if you need to sed them, they should go to CPPFLAGS instead.
> 
> This is a default behaviour in crossdev. May we CC spanky ?

I thought that it must be crossdev, but I wasn't sure. No, we give it to the maintainer. Perhaps we should check the whole tree for this mistake. thanks

[Comment 7 Peter Volkov (RETIRED) 2011-06-28 09:31:27 UTC]

Thank you guys. Fixed in the tree.