Bug 372091

Summary:	games-strategy/heroes3-1.3.1a-r2 please add ~amd64
Product:	Gentoo Linux	Reporter:	Marek Kozlowski <kozlowsm>
Component:	[OLD] Games	Assignee:	Gentoo Games <games>
Status:	RESOLVED NEEDINFO
Severity:	enhancement	CC:	amd64, pruzinat
Priority:	Normal	Keywords:	KEYWORDREQ
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	build.log heroes3 ebuild with support for amd64 platform

Description Marek Kozlowski 2011-06-17 19:39:57 UTC

games-strategy/heroes3-demo-1.3.1a-r2 has a keyword "~amd64" in addition to "x86"
games-strategy/heroes3-1.3.1a-r2 is for "x86" but there is no keyword for "amd64" architecture
I don't think that the system requirements differ. Maybe it's overlooked?

Reproducible: Always

Comment 1 Agostino Sarubbo gentoo-dev

2011-06-18 08:05:49 UTC

it requires a cdrom, I can't test it.

Comment 2 Markos Chandras (RETIRED) gentoo-dev

2011-07-18 16:17:30 UTC

Marek, does it work for you on an amd64 system?

Comment 3 Tomáš "tpruzina" Pružina (amd64 [ex]AT) 2011-07-19 22:38:32 UTC

Created attachment 280413 [details]
build.log

Emerge fails with this error:

Comment 4 Tomáš "tpruzina" Pružina (amd64 [ex]AT) 2011-07-19 22:43:19 UTC

Emerge fails (same error for any combination of useflags). When I do manually run official script installer and use simple uname hack for amd64 (script will die unless uname returns "x86") game runs (though without sound).

Comment 5 Ihar Hrachyshka 2012-06-05 12:56:49 UTC

It dies because ebuild doesn't copy a downloaded patch to a place where unpacker eclass would search for it. I've added the following to ebuild to be able to build the package:

src_unpack() {
    cdrom_get_cds hiscore.tar.gz
+    cp /usr/portage/distfiles/${P}-cdrom-x86.run ${DISTDIR} || die
-    use x86 && unpack_makeself ${P}-cdrom-x86.run
+    unpack_makeself ${P}-cdrom-x86.run
    use ppc && unpack_makeself ${P}-ppc.run
}

copy is needed on all platforms + on amd64 I needed to remove 'use x86' conditional so that the patch is really unpacked on my platform.

With these changes applied, I've successfully installed and run the game.

Comment 6 Ihar Hrachyshka 2012-06-05 13:09:21 UTC

Actually, the installation is fixed just by adding the patch file to SRC_URI for amd64 (then it's automatically copied to DISTDIR on unpack/prepare).

Comment 7 Ihar Hrachyshka 2012-06-05 13:12:43 UTC

Created attachment 314283 [details]
heroes3 ebuild with support for amd64 platform