Bug 370011

Summary:	x11-misc/xstroke fails because of underlinking
Product:	Gentoo Linux	Reporter:	Diego Elio Pettenò (RETIRED) <flameeyes>
Component:	New packages	Assignee:	Desktop Misc. Team <desktop-misc>
Status:	RESOLVED FIXED
Severity:	normal	CC:	kensington
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	372079
Attachments:	Build log xstroke-0.6-r2.ebuild patch xstroke-0.6-underlinking.patch

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2011-06-04 12:05:03 UTC

Created attachment 275769 [details]
Build log

Hello there!

You're getting this bug because the package in Summary failed to build in my tinderbox using the gold link editor from binutils. Before closing the bug as INVALID let me explain why this is still important!

The gold link editor does not support underlinking of shared objects, which is something I have described in my blog post:

http://blog.flameeyes.eu/2010/11/26/it-s-not-all-gold-that-shines-why-underlinking-is-a-bad-thing

Even the basic link editor (ld.bfd) has an option to support this but it is a heck to enable and get passed, so linking with gold is simply quicker.

Fixing underlinking provides optimized --as-needed builds (because the "softer" version no longer need to recover libraries that are underlinked), so it is a Good Thing To Do.

Thank you very much for the attention!

Comment 1 Michael Palimaka (kensington) gentoo-dev

2011-12-23 13:31:06 UTC

Created attachment 296739 [details, diff]
xstroke-0.6-r2.ebuild patch

- Fix underlinking
- Fix runtime deps (built forced-as-needed, checked using scanfelf)
- Fix build deps (checked with manual inspection + autodep tool)
- EAPI bump

Comment 2 Michael Palimaka (kensington) gentoo-dev

2011-12-23 13:31:21 UTC

Created attachment 296741 [details, diff]
xstroke-0.6-underlinking.patch

Comment 3 Jeroen Roovers (RETIRED) gentoo-dev

2012-09-12 01:51:37 UTC

Fixed without a revision bump. Thanks for the patch.