| Summary: | quickpkg cannot pack filenames with spaces | ||
|---|---|---|---|
| Product: | Portage Development | Reporter: | BigBug <romans.heimanis> |
| Component: | Tools | Assignee: | Portage team <dev-portage> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | Keywords: | InVCS |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
This solves the described behaviour for me
quickpkg-spaces.patch |
||
seems fixed in latest portage versions ;/ Created attachment 42399 [details, diff]
This solves the described behaviour for me
For me this bug is still present in the very latest version of portage.
# emerge --version
Portage 2.0.51-r2 (default-x86-1.4, gcc-3.3.4, glibc-2.3.4.20040808-r1, 2.6.8.1
i686)
I found the bug when building a package for openoffice, in which the files
under "/usr/share/applnk/OpenOffice.org 1.1/" are missing.
I attached a patch that fixes this issue for me, but as I am not a very skilled
programmer, feel free to improve the code.
I have to specify a comment. :/ Created attachment 42445 [details, diff]
quickpkg-spaces.patch
try this one out ... worked for me ;)
Instead of
rm -f ${PORTAGE_TMPDIR}/quickpkglog
the last line, which is not part of the patch, should become
rm -f ${PORTAGE_TMPDIR}/$1-quickpkglog
that last hunk shouldnt even be included, i filed a sep bug a while ago to address that issue Included the quickpkglog -> $1-quickpkglog as well, so you can dig that bug up and mark it InCVS too. :) -r15 has been released |
line 58 in /usr/bin/quickpkg cut -f 2 -d " " ${SRCDIR}/CONTENTS >${MYDIR}/filelist just print the second field of CONTENTS file (delimeter is space), and will print incorrect result if installed filename contain space[s] Reproducible: Always Steps to Reproduce: 1. make .ebuild for fake package which will install filename with spaces 2. emerge it 3. quickpkg packagename Actual Results: .tbz2 not containing this file Expected Results: .tbz2 shoud contain this file