Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 368525

Summary: sys-apps/openrc-0.8.2-r1: ethtool interface not working
Product: Gentoo Hosted Projects Reporter: Alois Schmid <alois.schmid>
Component: OpenRCAssignee: OpenRC Team <openrc>
Status: RESOLVED FIXED    
Severity: normal CC: aidanamarks, azamat.hackimov, g.olivier, openhs
Priority: Normal Keywords: InVCS
Version: unspecified   
Hardware: AMD64   
OS: Linux   
URL: http://git.overlays.gentoo.org/gitweb/?p=proj/openrc.git;a=commitdiff;h=0e4d169a40e01d74cf5ff399afe049a25543f0f6
Whiteboard: openrc:oldnet
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 382299    
Attachments: output of /etc/init.d/net.internet -d restart >& debug_output_interface_internet
/lib/rc/net/ethtool.sh patch
/lib/rc/net/ethtool.sh patch (unified diff format)

Description Alois Schmid 2011-05-24 06:57:35 UTC
I'm trying to put ethtool_change_internet="autoneg off speed 100 duplex full" in /etc/conf.d/net after my upgrade to openrc-0.8.2-r1. But it doesn't work. Instead I am getting the output of ethtool when invoked without any parameters and it seems ("/etc/init.d/net.internet -v restart" output) that the script tries to run 

/usr/sbin/ethtool '--change internet autoneg off speed 100 duplex full'

Running the command with the quotes gives me the same error output on the command line, while running the command without quotes works.

Reproducible: Always

Steps to Reproduce:
1. set some ethtool variable in /etc/conf.d/net
2. restart network interface with /etc/init.d/net.xxx restart
Comment 1 Alois Schmid 2011-05-24 07:01:07 UTC
Created attachment 274457 [details]
output of /etc/init.d/net.internet -d restart >& debug_output_interface_internet

Added output of
/etc/init.d/net.internet -d restart
Comment 2 Gilles OLIVIER 2011-06-03 08:53:56 UTC
I am facing the same bug (ethtool.sh involved?)

 in addition:

  ethtool set-ring option unsupported
Comment 3 Gilles OLIVIER 2011-06-04 00:32:37 UTC
Created attachment 275759 [details, diff]
/lib/rc/net/ethtool.sh patch

quick and dirty patch of ethtool.sh
Comment 4 Alois Schmid 2011-08-04 08:43:28 UTC
Patch (although quick and dirty) seems to fix the problem.

By the way, in openrc-0.8.3-r1 the problem still exists!
Comment 5 William Hubbs gentoo-dev 2011-08-04 13:27:24 UTC
This patch is not a unified diff, so I can't apply it with "git apply"
or "patch".

Thanks,

William
Comment 6 Gilles OLIVIER 2011-08-04 20:30:29 UTC
Created attachment 282109 [details, diff]
/lib/rc/net/ethtool.sh patch (unified diff format)

/lib/rc/net/ethtool.sh patch (unified diff format)
Comment 7 Gilles OLIVIER 2011-08-04 20:32:13 UTC
Alois, yes, i confirm, 0.8.3-r1 is also affected by the same bugs

please see attachement of my previous comment
Comment 8 Aidan Marks 2011-08-31 23:00:19 UTC
Gilles' patch fixed the ethtool parameters quoting issue that was causing it to fail on my system.
Comment 9 Christian Ruppert (idl0r) gentoo-dev 2011-09-18 12:49:53 UTC
This has been fixed in openrc-9999 through commit 0e4d169.

Thank you guys!

To apply this patch do:
# wget 'http://git.overlays.gentoo.org/gitweb/?p=proj/openrc.git;a=patch;h=0e4d169a40e01d74cf5ff399afe049a25543f0f6' -O /tmp/ethtool.patch
# cd /lib/rc/net/
# patch -p2 < /tmp/ethtool.patch