Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 367937

Summary: sys-fs/cryptsetup - dm-crypt-start.sh should not contain bashisms
Product: Gentoo Linux Reporter: Petr Šabata <contyk>
Component: [OLD] Core systemAssignee: Gentoo's Team for Core System packages <base-system>
Status: RESOLVED DUPLICATE    
Severity: normal    
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: Change the C-style for loop to a while loop

Description Petr Šabata 2011-05-18 17:21:46 UTC
All shell scripts should be POSIX compatible, not depending on a
specific shell implementation without explicitly stating so.

dm-crypt-start.sh uses a C-style for loop on lines 153-160

Reproducible: Always

Steps to Reproduce:
1. Look in the file.
Actual Results:  
A bashism is present.

Expected Results:  
No bashisms present.

cryptsetup-1.2.0-r1
Comment 1 Petr Šabata 2011-05-18 17:22:48 UTC
Created attachment 273849 [details, diff]
Change the C-style for loop to a while loop
Comment 2 Petr Šabata 2011-05-19 19:33:48 UTC
Comment on attachment 273849 [details, diff]
Change the C-style for loop to a while loop

There are many, many more things to fix...
Comment 3 SpanKY gentoo-dev 2011-05-28 15:32:33 UTC

*** This bug has been marked as a duplicate of bug 255528 ***