| Summary: | >sys-process/acct-6.5.5: initscript not completely openrc compatible | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Robert Trace <bugzilla-gentoo> |
| Component: | Current packages | Assignee: | Gentoo's Team for Core System packages <base-system> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 367793 | ||
| Attachments: |
Remove svc_(start|stop) and make openrc compatible
acct.initd.patch |
||
|
Description
Robert Trace
2011-05-17 20:52:44 UTC
Created attachment 273715 [details, diff]
Remove svc_(start|stop) and make openrc compatible
(In reply to comment #1) > Created attachment 273715 [details, diff] > Remove svc_(start|stop) and make openrc compatible This patch is not quite correct. openrc has a command, rc-service. It should be used to stop/start services. rc-service foo stop or rc-service foo start will stop or start service foo. (In reply to comment #2) > > This patch is not quite correct. Ok, I'll fix it up. I couldn't find much documentation about what services/commands were available or any best practices, so I just guessed based on what some other initscript was doing. I'll fix this patch as per your suggestion and I'll hunt down that other script and patch it too. Created attachment 273767 [details, diff]
acct.initd.patch
Updated patch to reflect William's comments. Fix and invert the logic a bit.
should be all set now in the tree. thanks for the report! http://sources.gentoo.org/sys-process/acct/files/acct.initd?r1=1.2&r2=1.3 |
