Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 367259

Summary: www-misc/reflector various Python problems
Product: Gentoo Linux Reporter: James Rowe <jnrowe>
Component: New packagesAssignee: Nathan Phillip Brink (binki) (RETIRED) <binki>
Status: RESOLVED FIXED    
Severity: trivial    
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description James Rowe 2011-05-14 16:34:36 UTC
The module for reflector is Reflector, so the ebuild should set PYTHON_MODNAME="Reflector.py".

It also isn't compatible with 2.5(new-style exception handling) or 2.4(same+empty base classes), so should set RESTRICT_PYTHON_ABIS="2.[45]" and PYTHON_DEPEND="*:2.6".

Probably be nice if src_install() used a tactic similar to metagen's to install the script for all supported Python versions too, so we users get the normal $script-$PYTHON_ABI entry points.

Thanks,

James
Comment 1 Nathan Phillip Brink (binki) (RETIRED) gentoo-dev 2011-05-20 13:02:23 UTC
(In reply to comment #0)
> The module for reflector is Reflector, so the ebuild should set
> PYTHON_MODNAME="Reflector.py".
> 
> It also isn't compatible with 2.5(new-style exception handling) or
> 2.4(same+empty base classes), so should set RESTRICT_PYTHON_ABIS="2.[45]" and
> PYTHON_DEPEND="*:2.6".

Thanks for checking these, I don't have anything older than python2.6 installed. And now the Reflector class is getting optimized :-).

> Probably be nice if src_install() used a tactic similar to metagen's to install
> the script for all supported Python versions too, so we users get the normal
> $script-$PYTHON_ABI entry points.

If this is unnecessary complication, I'd prefer to leave it and let users set EPYTHON or directly run reflector with `python3 $(which reflector)' if they really want.

Everything else is fixed in CVS.