Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 366177

Summary: media-libs/libcanberra should use systemd.eclass to install systemd units
Product: Gentoo Linux Reporter: Michał Górny <mgorny>
Component: [OLD] GNOMEAssignee: Gentoo Linux Gnome Desktop Team <gnome>
Status: RESOLVED FIXED    
Severity: enhancement CC: sound
Priority: Normal Keywords: InVCS
Version: unspecified   
Hardware: All   
OS: Linux   
URL: None
Whiteboard: None
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 365937    

Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2011-05-06 05:45:55 UTC
Upstream does supply a set of systemd unit files in the distribution tarball and an ability to control installation of those files through the --with/--without-systemdsystemunitdir option. The ebuild is currently unaware of these options, making installation of systemd units pkgconfig file dependant and thus automagic.

The ebuild shall use systemd.eclass to handle installation of the systemd unit files in a clean and unified way.

The preferred way to handle that is to use autotools-utils eclass, and call `systemd_to_myeconfargs' before `autotools-utils_src_configure', as in:

	inherit autotools-utils systemd

	src_configure() {
		local myeconfargs=(
			$(use_enable foo)
			--with-bar
		)

		systemd_to_myeconfargs
		autotools-utils_src_configure
	}

If you're not interested in migrating to autotools-utils, there is also a legacy `systemd_with_unitdir' function, which could be used like that:

	inherit systemd

	src_configure() {
		econf \
			$(use_enable foo) \
			--with-bar \
			"$(systemd_with_unitdir)"
	}

Currently introduction of the eclass will cause the package to install systemd unit files unconditionally. If you don't like that concept, feel free to take a vote on the appropriate gentoo-dev ml topic. The eclass behaviour might change in future.
Comment 1 Gilles Dartiguelongue (RETIRED) gentoo-dev 2011-05-08 13:52:57 UTC
+*libcanberra-0.28-r2 (08 May 2011)
+
+  08 May 2011; Gilles Dartiguelongue <eva@gentoo.org>
+  +libcanberra-0.28-r2.ebuild:
+  Add support for systemd, bug #366177.

Fixed, thanks for reporting.