Summary: | net-misc/connman should use systemd.eclass to install systemd units | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Michał Górny <mgorny> |
Component: | Current packages | Assignee: | Robert Piasek (RETIRED) <dagger> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | aeriksson |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 365937 |
Description
Michał Górny
2011-05-06 05:44:28 UTC
Hi, If I understand your class and you comments correctly, changing ebuild would force it to always install systemd files, even on computers without systemd installed. I believe eclass should make sure systemd is installed in the first place before proceeding with any units installation. (In reply to comment #1) > If I understand your class and you comments correctly, changing ebuild would > force it to always install systemd files, even on computers without systemd > installed. > I believe eclass should make sure systemd is installed in the first place > before proceeding with any units installation. As stated in the long message I pasted, this is not a place for this discussion. Eclass can be changed, while ebuilds randomly installing and not installing files are not a good idea. Currently I do not see any advantage of using this eclass. While I understand that we need better way of handling unit files, current eclass implementation doesn't support necessary bits to justify ebuild porting. With current automagic behavior unit files are only installed when systemd is present. (In reply to comment #3) > Currently I do not see any advantage of using this eclass. While I understand > that we need better way of handling unit files, current eclass implementation > doesn't support necessary bits to justify ebuild porting. > With current automagic behavior unit files are only installed when systemd is > present. Which implies that users migrating to systemd have to guess which packages would have installed such files and randomly rebuild them. Pushed to the tree. About the --with-systemdunitdir issue, I did some thinking and I'll probably add an optional argument to systemd_with_unitdir allowing to change the option name. This should be quite similar to what use_with provides. Ok, I have added an optional argument to systemd_with_unitdir [1]. I'd appreciate if you could update connman ebuild to use it. [1]:http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/eclass/systemd.eclass?r1=1.3&r2=1.4 That's now done. |