Summary: | patch to allow gnome-cd to work with ppc cd-roms | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Jonathan Nall <nall> |
Component: | Current packages | Assignee: | PPC Porters <ppc> |
Status: | VERIFIED TEST-REQUEST | ||
Severity: | normal | CC: | gnome |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | sound | ||
Package list: | Runtime testing required: | --- | |
Attachments: | tarball containing ebuild, new source code and patch |
Description
Jonathan Nall
2003-12-27 15:46:32 UTC
Created attachment 22719 [details]
tarball containing ebuild, new source code and patch
filelist:
gnome-media/
gnome-media/Manifest
gnome-media/files/
gnome-media/files/gstreamer-gnome-cd.patch
gnome-media/files/gst-cdparanoia-cdrom.c
gnome-media/files/gst-cdparanoia-cdrom.h
gnome-media/files/digest-gnome-media-2.4.1.1-r1
gnome-media/gnome-media-2.4.1.1-r1.ebuild
hmm, I kinda like the idea of having this default, mainly cause I dont' have a cable between my cdrom and the soundcards.... FYI: i've also posted this patch against gnome-cd itself. that bug is at: http://bugzilla.gnome.org/show_bug.cgi?id=86331 hopefully the gnome-media is open to the patch. hmm well, it is going the gstreamer way anyway, so in that sense i wouldn't mind much. After a quick look @ the patch here's a few questions i had : * It uses cdparanoia over the sys cdrom element because the latter would do what it does now (play needing a cable) ? * It includes linux/cdrom.h for info gathering i suppose, wouldn't it be nicer to have that done via gstreamer as well (don't think there's an element though) ? * It use a gconf call for getting the audiosink, why not use gst_gconf_get_default_audio_sink ? * It uses cdparanoia over the sys cdrom element because the latter would do what it does now (play needing a cable) ? i'm not sure what you mean by "the sys cdrom element". * It includes linux/cdrom.h for info gathering i suppose, wouldn't it be nicer to have that done via gstreamer as well (don't think there's an element though) ? yeah, i don't know of an element. i agree doing it all in gstreamer would be ideal. * It use a gconf call for getting the audiosink, why not use gst_gconf_get_default_audio_sink ? good point. i didn't know about that call. i've modified the source locally to reflect that change. thanks. a new tarball then perhaps? What's the current status on this bug. Does it still needs testing on ppc? if gnome-cd works with ppc cd-roms it isn't .. Ok , so we need a Gnome user, with working audio, to test gnome-cd. I don't have audio on the G5. Any takers? gnome-media-2.8.0 (current ~pcc) does not play CDs. Rather, it plays them, but no sound comes from the loudspeakers. xmms (xmms-1.2.10-r9 xmms-cdread-0.14a-r2) plays them without problem can someone test gnome-cd from gnome-media on ppc ? If that works then this can be closed. gnome-media-2.8 - plays audio cds, no sound gnome-media-2.10 - plays audio cds, with sound In other words, it looks to be fixed in >=2.10. Should we leave that bug open until gnome-2.10 hits stable in the future? Works for me, closing. |