Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 365373

Summary: app-portage/gentoolkit: echangelog: add flag to ignore removals
Product: Gentoo Linux Reporter: Samuli Suominen (RETIRED) <ssuominen>
Component: Current packagesAssignee: Portage Tools Team <tools-portage>
Status: CONFIRMED ---    
Severity: normal CC: betelgeuse, binki, jer, pchrist, pva
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Samuli Suominen (RETIRED) gentoo-dev 2011-04-30 05:13:21 UTC
It's not useful for users to see messages like "old" or "rm" or "remove old", so echangelog shouldn't log removals by default.

But there should be a special parameter to include removals in ChangeLog for cases when it's useful, for example, like when last stable version was removed.
Comment 1 SpanKY gentoo-dev 2011-04-30 05:16:31 UTC
i tend to disagree.  if you dont want echangelog to include those things, then dont use echangelog when making that commit.
Comment 2 Samuli Suominen (RETIRED) gentoo-dev 2011-04-30 05:20:09 UTC
(In reply to comment #1)
> i tend to disagree.  if you dont want echangelog to include those things, then
> dont use echangelog when making that commit.

well I agree with you. parameter to ignore removals works just as fine for me.
Comment 3 Peter Volkov (RETIRED) gentoo-dev 2011-04-30 07:42:42 UTC
I don't think this feature is even needed as our policy requires to document all changes but typos and comments. Until policy Changes this bug is really wontfix.


But it's always possible to improve situation. I guess it's good idea to update ChangeLog format to be more terse. E.g.:

  29 Apr 2011; Kacper Kowalik <xarthisius@gentoo.org> transmission-2.13.ebuild:
  ppc stable wrt #361305

Could be written in one line if we drop:
1. name - dev's uid is nickname so it's not necessary to repeat name every time
2. @gentoo.org
3. .ebuild suffix is redundant too

Then it's possible to have this message (and lot's of similar messages) in one line:

  29 Apr 2011; xarthisius transmission-2.13: ppc stable wrt #361305

Also redundant empty lines could be dropped too.
Comment 4 Petteri R├Ąty (RETIRED) gentoo-dev 2011-04-30 08:07:16 UTC
http://devmanual.gentoo.org/ebuild-writing/misc-files/changelog/index.html

devmanual requires all non-trivial changes to be documented in ChangeLog so as longs as that policy is in place this should not be done.
Comment 5 Samuli Suominen (RETIRED) gentoo-dev 2011-04-30 08:11:41 UTC
(In reply to comment #4)
> http://devmanual.gentoo.org/ebuild-writing/misc-files/changelog/index.html
> 
> devmanual requires all non-trivial changes to be documented in ChangeLog so as
> longs as that policy is in place this should not be done.

Removing an unused ebuild is not the same as changing an ebuild.   We have no policy for logging removals, and that's how it should be.
Comment 6 Peter Volkov (RETIRED) gentoo-dev 2011-04-30 09:12:18 UTC
(In reply to comment #5)
> Removing an unused ebuild is not the same as changing an ebuild.

If ebuild was man, then removal means death, and really such change is quite drastic change for all who are still alive ;)
Comment 7 SpanKY gentoo-dev 2011-05-01 22:09:16 UTC
not really.  echangelog options are independent of policy.  if you want to talk policy, go to g-dev ml.  plus, people can easily use echangelog on trees other than gentoo-x86 where gentoo-x86 policy obviously has no bearing.