| Summary: | emerge-webrsync incorrect/incomplete proxy error codes handling | ||
|---|---|---|---|
| Product: | Portage Development | Reporter: | Sergey S. Starikoff <Ikonta> |
| Component: | Enhancement/Feature Requests | Assignee: | Portage team <dev-portage> |
| Status: | UNCONFIRMED --- | ||
| Severity: | normal | ||
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: | https://bugs.gentoo.org/show_bug.cgi?id=611226 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 912589 | ||
|
Description
Sergey S. Starikoff
2011-04-27 05:50:47 UTC
You could ask to get bug #104547 reopened. *** This bug has been marked as a duplicate of bug 104547 *** I disagree with marking this bug as duplicate of 104547. 104547 is enchancement request for proxy in general. This bug is about that emerge-webrsync fetch portage archive function (unlike distfiles fetch) incorrectly handles proxy error codes (or doesn't handle them at all) in the case with usind squid proxy server with authorized (basic mech is used) web access. This bug is not enchancement request, it's the issue report! (In reply to comment #0) > Overwriting in /etc/make.conf default values of FETCHCOMMAND and RESUMECOMMAND > variables adding --proxy-user and --proxy-password options make emerge-webrsync > operates normally. That seems like a reasonable solution. So, doesn't that solve your problem? (In reply to comment #3) > (In reply to comment #0) > > Overwriting in /etc/make.conf default values of FETCHCOMMAND and RESUMECOMMAND > > variables adding --proxy-user and --proxy-password options make emerge-webrsync > > operates normally. > > That seems like a reasonable solution. So, doesn't that solve your problem? It not seems, it is the solution of the issue in the part of _operability_. :) But the bug is not about portage operability (it works fine ;) ), it's about handling and reporting errors (I've rememebered that it's a time to redefine FETCHCOMMAND and RESUMECOMMAND variables only after reading emerge error while trying to install app-portage/emerge-delta-webrsync, not error message of emerge-webrsync). Normally emerge-webrsync should provide error message similiar with emerge. The thing is, in order for FETCHCOMMAND and RESUMECOMMAND to be useful, portage needs to make as little assumptions about them as possible. It's not really feasible to make assumptions about error codes, since we don't want to assume that FETCHCOMMAND calls wget rather than curl or whatnot. So, I think the best that we can do allow the message from FETCHCOMMAND to pass through. Looking at the code, the fetch_file() function doesn't seem to redirect output, so I don't understand why you didn't see any output from FETCHCOMMAND. (In reply to comment #5) > So, I think the best that we can do allow the message from FETCHCOMMAND to pass > through. Looking at the code, the fetch_file() function doesn't seem to > redirect output, so I don't understand why you didn't see any output from > FETCHCOMMAND. emerge fetch function checks result and normally translates FETCHCOMMAND messages. emerge-webrsync fetch function doesn't check the result (were queried files fetched or not) and all errors (including proxy authentification errors) interpreters as file, not present on a mirror (at the time, where emerge fetch function translates proxy error message). |
