Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 364933

Summary: media-tv/v4l-dvb-hg-0.1-r4: problems with local patches
Product: Gentoo Linux Reporter: Timo Bachert <timobachert>
Component: New packagesAssignee: Television related Applications in Gentoo's Portage <media-tv>
Status: RESOLVED WONTFIX    
Severity: normal CC: Thomas.Rausch
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Timo Bachert 2011-04-26 13:49:24 UTC
The ebuild v4l-dvb-hg-r4 (the current one) fails to compile, if local patches are used.

In the method src_prepare the variable DVB_LOCAL_PATCHES is checked. If there are local patches specified, it does a "grep -q" for the patch in linux/drivers of the working dir. Depending on the result it does cd {S} or cd {s}/... before doing the epatch command.

If the last of the specified patches results in cd {S}/.. the next step after the local patches (make allmodconfig) can not be done, because the current directory must be {S} and is {S}/.. .

This could be fixed by simply adding a cd {S} after processing the local patches.

Reproducible: Always

Steps to Reproduce:
1. Set DVB_LOCAL_PATCHES with a patch file for the v4l dvb driver that results in doing cd {S}/.. at applying the patch
2. Try to emerge the v4l-dvb-hg package
Actual Results:  
Emerge fails after creating the firmware.
It doesn't fail at the place where it is in wrong directory, but it fails at a later place, because some of the actions before were not done (because of the wrong dir).

Expected Results:  
It should continue to emerge (what it does if I add the cd {S} to the ebuild in src_prepare after applying local patches)

No emerge --info ouput, because this shouldn't be necessary in the given case.
Comment 1 Pacho Ramos gentoo-dev 2012-12-25 13:12:41 UTC
dropped