Summary: | dev-util/duma fails to build (error: open with O_CREAT in second argument needs 3 arguments) | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Diego Elio Pettenò (RETIRED) <flameeyes> |
Component: | Current packages | Assignee: | No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed> |
Status: | CONFIRMED --- | ||
Severity: | normal | CC: | ComputerDruid, tdalman |
Priority: | Normal | Keywords: | PATCH |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 259417 | ||
Attachments: |
Build log
patch to fix O_CREATE without mode |
Description
Diego Elio Pettenò (RETIRED)
2011-04-14 08:51:57 UTC
dev-util/duma-2.5.15-r1 - I got it compiled with gcc-4.6.2 Works here fine too with GCC-4.6.2. The error does not seem to be GCC related ... Hmm. Strange. Compile without problems. No issue with gcc-4.6.3 I could not reproduce this even with gcc 4.6.0 (Gentoo 4.6.0 p1.2, pie-0.4.5) on amd64. Will retry with x86 if I have time. Is it possible this only occurs on x86? You won't see it, cause it happens only for -D_FORTIFY_SOURCE=2 Diego must have had in gcc specs, because ebuild appends -U_FORTIFY_SOURCE. It's a bug, but by all means it shouldn't block gcc-4.6 Created attachment 338830 [details, diff]
patch to fix O_CREATE without mode
Simple/stupid patch that should fix the issue.
Two things to note about this problem:
* inside an #if defined(WIN32) is a call to _open. This probably needs the mode argument as well, but I have no way to test that.
* This code path is never actually executed. it is only executed if DUMA_OUTPUT_FILE is non-NULL, and it is always set to NULL in the source. So this is only a theoretical bug, in a sense.
Regardless, it should probably be fixed. I will work on contacting the upstream developer about this.
|