Summary: | sys-apps/openrc: /etc/init.d/procfs should check for /sys/module/usbcore before attempting usbcore module loading | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Xake <kanelxake> |
Component: | New packages | Assignee: | OpenRC Team <openrc> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | Keywords: | Inclusion |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | Patch based on comment #1 |
Description
Xake
2011-04-14 07:41:11 UTC
Created attachment 269969 [details, diff] Patch based on comment #1 It is reasonable to check in /sys also, but the purpose of that file is to mount miscellaneous filesystems somewhere under /proc. I don't like poluting the purpose of each init script. Having said that, I'm not sure where else to put it. Hmm, further point: what about the code following those lines which tries to mount a ubsfs at /proc/bus/usb? I think its okay because if you're using the deprecated USB device filesystem then /proc/bus/usb exists and you want to mount usbfs there. If you are not using it, then the same information is available at /sys/bus/usb/drivers/usbfs. In both cases the code behaves as you want. patch looks fine to me. that said, i dont see any problem with the existing code other than `modprobe` is silently executed on newer systems when it isnt necessary. the -q flag keeps any output from being shown. Okay committed to the repo: http://git.overlays.gentoo.org/gitweb/?p=proj/openrc.git;a=commit;h=ac56ab7f6df616a7a40878b59f647b8042108def |