Summary: | media-video/setpwc fails to build with linux-headers 2.6.38 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Diego Elio Pettenò (RETIRED) <flameeyes> |
Component: | New packages | Assignee: | Patrick Kursawe (RETIRED) <phosphan> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | media-video |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 359595 | ||
Attachments: |
Build log
Patch to convert setpwc from V4L1 to V4L2 |
Description
Diego Elio Pettenò (RETIRED)
2011-04-13 10:38:49 UTC
I get the same error with gcc-4.5.2. Thus, this is not a blocker for gcc-4.6. Gha, thanks Tolga, I got the wrong blocker by force of habit. Looks like the issue is that setpwc is still using V4L1 API which is being deprecated. Probably would need porting to V4L2 (kernel driver was converted to V4L2 last summer/fall) Created attachment 274211 [details, diff]
Patch to convert setpwc from V4L1 to V4L2
Patch to make setpwc compile against recent linux-headers, including those that drop linux/videodev.h include (and thus support for compiling V4L-1 programs)
This patch replaces V4L-1 ioctls with appropriate V4L2 ioctls and changes include from linux/videodev.h to linux/videodev2.h.
Note: did minor runtime testing against 2.6.39 kernel, no idea if it works as expected against older kernels where pwc driver is still V4L1 based.
Many thanks for the patch, Bruno! I hope it works, and no doubt you must have gotten yourself lots of tree-hugs, it would have been horrible having to throw away a perfectly working webcam because of this (even though its specs are outdated by now, but that's OK for the occasional use, and isn't Linux supposed to be great for running older hardware...) :) I hope someone looks into this soon and removes media-video/setpwc from package.mask to spare us the annoying message every time we update world :) FYI: my patch or a variant of it has been applied upstream and a new version released there. Please consider bumping setpwc to 1.3 to resolve this bug! 1.3 in Portage, thanks guys. Also unmasked now. |