| Summary: | dev-util/buildbot-0.8.3_p1 fails tests with root permissions | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Thomas Kahle (RETIRED) <tomka> |
| Component: | Current packages | Assignee: | Python Gentoo Team <python> |
| Status: | RESOLVED OBSOLETE | ||
| Severity: | normal | ||
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | build.log with test failures | ||
|
Description
Thomas Kahle (RETIRED)
2011-04-13 03:33:15 UTC
try reemerging this with the mail useflag and let us know what happens.
mail should fix buildbot.test.unit.test_contrib_buildbot_cvs_mail.TestBuildbotCvsMail.test_buildbot_cvs_mail_from_cvs1_11
===============================================================================
[FAIL]
{snip}
buildbot.test.unit.test_contrib_buildbot_cvs_mail.TestBuildbotCvsMail.test_buildbot_cvs_mail_from_cvs1_12
===============================================================================
[ERROR]
{snip}
may get the weblinks bit too but we shall see
Looks similar with USE="mail":
[FAIL]
Traceback (most recent call last):
File "/var/tmp/portage/dev-util/buildbot-0.8.3_p1/work/buildbot-0.8.3p1/build-2.6/lib/buildbot/test/unit/test_contrib_buildbot_cvs_mail.py", line 108, in test_buildbot_cvs_mail_from_cvs1_11
self.assertOutputOk(p, stdoutdata, golden_1_11_regex )
File "/var/tmp/portage/dev-util/buildbot-0.8.3_p1/work/buildbot-0.8.3p1/build-2.6/lib/buildbot/test/unit/test_contrib_buildbot_cvs_mail.py", line 86, in assertOutputOk
self.failUnlessEqual(p.returncode, 0, "subprocess exited uncleanly")
twisted.trial.unittest.FailTest: subprocess exited uncleanly
not equal:
a = 2
b = 0
[...]
Comment on attachment 269755 [details] build.log with test failures Is revmacros.html in the search path when the tests are run? It should be at /var/tmp/portage/dev-util/buildbot-0.8.3_p1/work/buildbot-0.8.3p1/build-2.6/lib/buildbot/status/web/templates/revmacros.html The test failures for contrib are expected when running tests from an installed copy of buildbot - see https://github.com/djmitche/buildbot/commit/9bfae71cd723af157ee8f150af78cf7009752b43 (In reply to comment #3) > Comment on attachment 269755 [details] > build.log with test failures > > Is revmacros.html in the search path when the tests are run? It should be at > /var/tmp/portage/dev-util/buildbot-0.8.3_p1/work/buildbot-0.8.3p1/build-2.6/lib/buildbot/status/web/templates/revmacros.html I don't really know what that means, the file is not an executable? > The test failures for contrib are expected when running tests from an installed > copy of buildbot - see > https://github.com/djmitche/buildbot/commit/9bfae71cd723af157ee8f150af78cf7009752b43 In any case, the tests should be patched to give a working set for running with FEATURES="test". If some are expected to fail, the optimal solution is to patch those away. I'm not really interested in the package per se, I reported this b/c I found it during archtesting. Thanks. Could you try with FEATURES="userpriv usersandbox"? Anyway all tests pass for me. (In reply to comment #4) > > Is revmacros.html in the search path when the tests are run? It should be at > > /var/tmp/portage/dev-util/buildbot-0.8.3_p1/work/buildbot-0.8.3p1/build-2.6/lib/buildbot/status/web/templates/revmacros.html > > I don't really know what that means, the file is not an executable? What is the output of /var/tmp/portage/dev-util/buildbot-0.8.3_p1/work/buildbot-0.8.3p1/build-2.6/lib/buildbot/status/web/templates/revmacros.html And no, it should not be executable - it's a Jinja template file. > In any case, the tests should be patched to give a working set for running with > FEATURES="test". If some are expected to fail, the optimal solution is to > patch those away. I'm not really interested in the package per se, I reported > this b/c I found it during archtesting. Thanks. Agreed, and the commit in comment #3 is probably a good way to do so. Er, what is the output of file /var/tmp/portage/dev-util/buildbot-0.8.3_p1/work/buildbot-0.8.3p1/build-2.6/lib/buildbot/status/web/templates/revmacros.html (In reply to comment #7) > Er, what is the output of > > file > /var/tmp/portage/dev-util/buildbot-0.8.3_p1/work/buildbot-0.8.3p1/build-2.6/lib/buildbot/status/web/templates/revmacros.html .../web has no subfolder templates. Anyway, arfrever is right, privelage issue: Passes all tests with userpriv and usersandbox. As upstream maintainer, this isn't something I can fix. I pointed out the patch that fixes the problem with running tests on an installed instance. The optimal solution would be to stabilize something more modern, but barring that, patching out any tests that fail is an easy fix. This version is no longer in the tree. Please re-open this bug if the problem persists in new versions |