Bug 363213 – dependency on gtk-doc should be increased from >=1.13 to >=1.15-r2

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Imran Sher Rafique 2011-04-12 02:09:52 UTC]

Compiling the latest stable dev-libs/glib-2.26.1-r1 failed (with USE=doc), because of an issue with the already installed gtk-doc.

This issue was already fixed in gtk-doc (see bug 334489 for details), but the dependency info in the glib ebuilds haven't been updated to account for this.

In the latest stable (2.26.1-r1) and unstable (2.28.5) glib ebuilds, the DEPEND definition has ">=gtk-doc-1.13". This should be bumped up to at least ">=gtk-doc-1.15-r2" .

Reproducible: Always

Steps to Reproduce:
1. USE="doc" emerge dev-libs/glib
2.
3.
Actual Results:  
Use of uninitialized value $highlighted_source in substitution (s///) at /usr/bin/gtkdoc-fixxref line 484.
Can't delete html/_temp_src.23813.h.html: No such file or directory at /usr/bin/gtkdoc-fixxref line 489.
make[4]: *** [html-build.stamp] Error 2
make[3]: *** [all-recursive] Error 1
make[2]: *** [all-recursive] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2
emake failed
 * ERROR: dev-libs/glib-2.26.1-r1 failed (compile phase):
 *   emake failed
 * 
 * Call stack:
 *     ebuild.sh, line   56:  Called src_compile
 *   environment, line 4141:  Called _eapi2_src_compile
 *     ebuild.sh, line  665:  Called die
 * The specific snippet of code:
 *        emake || die "emake failed"


Expected Results:  
successful build & install of dev-libs/glib

[Comment 1 Gilles Dartiguelongue (RETIRED) 2011-04-12 07:08:42 UTC]

>=gtk-doc-1.15 is already the oldest version you can find in tree so

[Comment 2 Imran Sher Rafique 2011-04-12 22:58:17 UTC]

(In reply to comment #1)
> >=gtk-doc-1.15 is already the oldest version you can find in tree so

Err, so what ...

If glib is upgraded, and the currently installed gtk-doc is 1.13, then because of the outdated $DEPEND, gtk-doc won't be upgraded, and building of glib will fail.

So either
1) folks can google for the error msgs from the failed glib build, find bug 334489, see that it was an issue with gtk-doc which was fixed in 1.15-r2, and then *manually* upgrade gtk-doc

or

2) fix the outdated $DEPEND in glib, and emerge will automatically upgrade gtk-doc if necessary.

Not trying to sound patronising or anything, but is this a serious discussion? (ie: is this not something which is ordinarily fixed?). I honestly assumed that someone just forgot to grep for gtk-doc in the DEPEND block for current ebuilds, when gtk-doc-1.15-r2 was added.

[Comment 3 Pacho Ramos 2011-04-13 17:17:16 UTC]

(In reply to comment #2)
> I honestly assumed that
> someone just forgot to grep for gtk-doc in the DEPEND block for current
> ebuilds, when gtk-doc-1.15-r2 was added.

Needing to update all DEPENDs from all ebuilds to 1.15-r2 doesn't look viable to me :-|

[Comment 4 Imran Sher Rafique 2011-04-13 22:38:52 UTC]

(In reply to comment #3)
> Needing to update all DEPENDs from all ebuilds to 1.15-r2 doesn't look viable
> to me :-|

Ok, if gentoo devs don't want to fix any existing ebuilds with updated $DEPEND-ency info, then at least a note should be added to each pkg which is affected, so that *future* ebuilds will take note of the changed dep. Perhaps a 'FutureChanges' file to go along with the existing 'ChangeLog'.

Otherwise, these required changes seem to slip through the cracks. Currently you have a number of glib ebuilds which were added to the tree *AFTER* the fixed gtk-doc-1.15-r2, but which still have the wrong $DEPEND info (hence this bug).

Knowingly keeping a tree with known broken dependency info just seems, strange ...

[Comment 5 Pacho Ramos 2011-04-14 07:39:36 UTC]

Maybe we could add a blocker of broken gtk-doc versions to gnome metas... :-/

[Comment 6 Pacho Ramos 2011-06-05 13:12:19 UTC]

+  05 Jun 2011; Pacho Ramos <[e-mail]> glib-1.2.10-r5.ebuild,
+  -files/glib-2.24-punt-python-check.patch,
+  -files/glib-2.26.1-gsettings-read.patch,
+  -files/glib-2.26.1-locked-message.patch, -glib-2.28.5.ebuild,
+  glib-2.28.7.ebuild:
+  Block broken gtk-doc versions that causes problems like bug #363213. Remove
+  old. Make repoman happier with glib-1.
+