Bug 360853

Summary:	xfce-base/thunar-1.2.1 translation falling back to english
Product:	Gentoo Linux	Reporter:	Martin Jürgens <martin.accounts>
Component:	Current packages	Assignee:	XFCE Team <xfce>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	Normal
Version:	unspecified
Hardware:	AMD64
OS:	Linux
See Also:	https://bugzilla.xfce.org/show_bug.cgi?id=4746
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	fixes clobbering setlocale() calls

Description Martin Jürgens 2011-03-28 01:15:47 UTC

Created attachment 267465 [details]
fixes clobbering setlocale() calls

I have had problems with Thunar's translation falling back to "C" locale
or whatever is indicated in ~/.config/user-dirs.locale. The problem seem to be
2 setlocale() calls which do not properly save (i.e. strdup()) the old locale.

I have also submitted a patch to the XFCE people (see https://bugzilla.xfce.org/show_bug.cgi?id=4746).

Patch tested with thunar-1.2.1 on Gentoo (x86_64). 

Maybe it should just be added to the ebuild until it gets fixed upstream.

This is my first patch submit to Gentoo. Just let me know if you need anything
else.

Comment 1 Samuli Suominen (RETIRED) gentoo-dev

2011-08-05 12:33:01 UTC

Comment on attachment 267465 [details]
fixes clobbering setlocale() calls

As per http://bugzilla.xfce.org/show_bug.cgi?id=4746#c3 this one should use g_strdup instead, and then g_free it

Comment 2 Samuli Suominen (RETIRED) gentoo-dev

2011-08-09 11:02:56 UTC

*thunar-1.2.2-r1 (09 Aug 2011)

  09 Aug 2011; Samuli Suominen <ssuominen@gentoo.org> +thunar-1.2.2-r1.ebuild,
  +files/thunar-1.2.2-locale.patch:
  Fix translation issues noticed with at least xdg-user-dirs wrt #360853 as
  reported by Martin Jürgens. Patch is from upstream #4746 by Mark Trompell.