Summary: | dev-libs/lzo-2.04 ignores CFLAGS/CCASFLAGS when compiling assembly (breaks portage-multilib) | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Nathan Phillip Brink (binki) (RETIRED) <binki> |
Component: | [OLD] Library | Assignee: | No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | esigra |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | 365407 | ||
Bug Blocks: | 306835 | ||
Attachments: |
build.log
emerge --info lzo-2.04-asm-makefile.patch lzo-2.04.ebuild-asm-makefile.patch |
Description
Nathan Phillip Brink (binki) (RETIRED)
2011-03-25 05:37:52 UTC
Created attachment 267163 [details]
build.log
Created attachment 267165 [details]
emerge --info
Created attachment 267167 [details, diff]
lzo-2.04-asm-makefile.patch
This fixes the issue by killing the explicit make rules for building .S files and preferring automake's build rules. It also invokes AM_PROG_AS, which will set up CCAS and CCASFLAGS, where CCAS=$(CC) and CCASFLAGS=$(CFLAGS) which gets the behavior of the compiler driver being called with $(CFLAGS) which is required for multilib-portage to work.
Created attachment 267169 [details, diff]
lzo-2.04.ebuild-asm-makefile.patch
The changes necessary to lzo-2.04.ebuild to get the patch working properly.
A simple eautoreconf does not work with lzo. I have no idea where lzo gets the mfx_* autoconf macros from, but it certainly does not ship them in m4/ like it should. To fix this, the sed expression grabs all of these macros from aclocal.m4 and stores them into acinclude.m4 (otherwise eautoreconf causes an error; also, eautoreconf is required because the prior patch touches configure.ac and src/Makefile.am).
Patch emailed to upstream, awaiting reply. Another way to fix this is to fix bug 365407, where upstream fixes this bug in a similar way to the way attachment 267167 [details, diff] fixes it. Fixed in dev-libs/lzo-2.05 (bug 365407). |