Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 360161

Summary: net-misc/unison[gtk] is missing application menu entry
Product: Gentoo Linux Reporter: Bruce Guenter <bruce>
Component: Current packagesAssignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status: RESOLVED FIXED    
Severity: enhancement CC: mail, sam
Priority: Normal Keywords: Inclusion, PullRequest
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/gentoo/gentoo/pull/17962
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on: 750335    
Bug Blocks:    
Attachments: Patch to add desktop entry and icons
Unison desktop entry
Unison icon (SVG)
Unison icon (XPM)

Description Bruce Guenter 2011-03-23 15:35:16 UTC
The GTK component of unison runs a GUI interface but is missing a menu entry.

Reproducible: Always
Comment 1 Bruce Guenter 2011-03-23 15:36:04 UTC
Created attachment 266995 [details, diff]
Patch to add desktop entry and icons
Comment 2 Bruce Guenter 2011-03-23 15:36:34 UTC
Created attachment 266997 [details]
Unison desktop entry
Comment 3 Bruce Guenter 2011-03-23 15:37:14 UTC
Created attachment 266999 [details]
Unison icon (SVG)
Comment 4 Bruce Guenter 2011-03-23 15:38:01 UTC
Created attachment 267001 [details]
Unison icon (XPM)

Copied from Ubuntu's packaging
Comment 5 Wormo (RETIRED) gentoo-dev 2011-03-27 05:12:36 UTC
Thanks for submitting your enhancements, assigning to unison maintainers
Comment 6 Maciej S. Szmigiero 2019-07-03 11:46:44 UTC
That's a long time to add a desktop menu entry...
Comment 7 Larry the Git Cow gentoo-dev 2020-10-19 02:54:41 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=208a9be49ea4a768e4f513db32f19417086d5664

commit 208a9be49ea4a768e4f513db32f19417086d5664
Author:     Volkmar W. Pogatzki <gentoo@pogatzki.net>
AuthorDate: 2020-10-17 12:09:51 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2020-10-19 02:54:37 +0000

    net-misc/unison: .desktop file, menu icon
    
    Closes: https://bugs.gentoo.org/360161
    
    Package-Manager: Portage-3.0.8, Repoman-3.0.1
    Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>
    Closes: https://github.com/gentoo/gentoo/pull/17962
    Signed-off-by: Sam James <sam@gentoo.org>

 net-misc/unison/unison-2.48.15_p4.ebuild | 15 +++++++++++++++
 net-misc/unison/unison-2.51.3_rc2.ebuild | 16 +++++++++++++++-
 2 files changed, 30 insertions(+), 1 deletion(-)
Comment 8 Maciej S. Szmigiero 2020-10-19 13:23:32 UTC
Unfortunately, the generated .desktop file is wrong and so it doesn't work.

The file contains the following exec parameters:
> Exec=Unison
> TryExec=Unison

But unison is installed as "unison" so both parameters should begin with lowercase "u" for the provided .desktop file to actually work (and in the xfce4 DE case, to even show in the "Applications" menu).

Please repoen this bug.
Comment 9 Larry the Git Cow gentoo-dev 2020-10-20 03:09:27 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dfcfaa586a6aee2b81100c59995480f632f669dc

commit dfcfaa586a6aee2b81100c59995480f632f669dc
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2020-10-20 03:08:18 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2020-10-20 03:09:22 +0000

    net-misc/unison: fix .desktop and GUI build
    
    Closes: https://bugs.gentoo.org/360161
    Closes: https://bugs.gentoo.org/750125
    Package-Manager: Portage-3.0.8, Repoman-3.0.1
    Signed-off-by: Sam James <sam@gentoo.org>

 .../unison/{unison-2.48.15_p4.ebuild => unison-2.48.15_p4-r1.ebuild}  | 4 ++--
 net-misc/unison/unison-2.51.3_rc3.ebuild                              | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)