| Summary: | =net-analyzer/tcpreplay-3.4.4-r1 fails tests with "non-standard" NIC names | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Thomas Kahle (RETIRED) <tomka> |
| Component: | Current packages | Assignee: | Gentoo Netmon project <netmon> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | DuPol |
| Priority: | Normal | ||
| Version: | 2007.0 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
build.log with test failures
Let user define which nic to use |
||
|
Description
Thomas Kahle (RETIRED)
2011-03-18 12:12:51 UTC
Created attachment 266357 [details]
build.log with test failures
[tcprewrite] Reduce TTL: OK [tcprewrite] TOS test: OK [tcprewrite] MTU Truncate test: OK make[1]: Target `test' not remade because of errors. make[1]: Leaving directory `/var/tmp/portage/net-analyzer/tcpreplay-3.4.4-r1/work/tcpreplay-3.4.4/test' make: *** [test] Error 2 [33;01m*[0m Note, that some tests require eth0 iface to be UP. [...] Was it UP? (In reply to comment #2) > [tcprewrite] Reduce TTL: OK > [tcprewrite] TOS test: OK > [tcprewrite] MTU Truncate test: OK > make[1]: Target `test' not remade because of errors. > make[1]: Leaving directory > `/var/tmp/portage/net-analyzer/tcpreplay-3.4.4-r1/work/tcpreplay-3.4.4/test' > make: *** [test] Error 2 > [33;01m*[0m Note, that some tests require eth0 iface to be UP. > [...] > > Was it UP? For historical reasons I have no eth0, only eth1. IMHO the test can not assume eth0 to be up. It also says: NOTICE: Tests must be run as root Created attachment 266467 [details, diff] Let user define which nic to use (In reply to comment #3) > For historical reasons I have no eth0, only eth1. IMHO the test can not assume > eth0 to be up. It also says: > > NOTICE: Tests must be run as root This patch to the ebuild lets the user specify which nic is to be used for tests by setting TCPREPLAY_NIC and TCPREPLAY_NIC2 variables e.g. in make.conf. They default to eth0 which is the current behavior. Additionally, missing quotes around ${FILESDIR} have been added. (In reply to comment #4) > Created attachment 266467 [details, diff] > Let user define which nic to use I can't really tell what file/revision you're patching there. Also, why not default to lo instead of eth0. lo should be widely available. Also, downgrading Importance since the test phase output already makes it very clear why it can't succeed. I wonder if this should even block the stabilisation bug, as that's about having a better version stable, and not about petty issues on somebody's test system. Maybe someone else in netmon wants to cut in here? (In reply to comment #5) > (In reply to comment #4) > Also, downgrading Importance since the test phase output already makes it very > clear why it can't succeed. Test phase output can be misleading because you may have patched around things without adjusting the output. Like mentioned before, it also says "Tests have to be run as root" which 'makes very clear why it can't succeed' (although it does not seem to be the reason). > I wonder if this should even block the > stabilisation bug, as that's about having a better version stable You are right about my 'petty' issues. Archtesting is a boring procedure and false positives in tests don't make it easier. (In reply to comment #5) > I can't really tell what file/revision you're patching there. This patch is for tcpreplay-3.4.4-r1.ebuild,v 1.2 2011/03/14 19:18:36 hwoarang > Also, why not default to lo instead of eth0. lo should be widely available. I don't know about the test internals. Right now, tests default to eth0, so I made it behave like it was before. If you feel this should be lo, adjust it accordingly. I am not the maintainer, I just proposed a solution that worked for my setup. If you default to lo, you probably can drop the variable stuff because if you have a nic different than eth0 up, you should have lo up as well. BR, Dustin Comment on attachment 266467 [details, diff]
Let user define which nic to use
In the current ebuilds, --with-testnic* is never defined, and I still don't see where this patch would apply. It defaults to eth0 for both nic[12] on Linux systems, which seems fine to me.
It probably fails with "predictable network interface names"[1] too. [1] http://www.freedesktop.org/wiki/Software/systemd/PredictableNetworkInterfaceNames/ I've set it to use =lo in 4.0.2, which should probably work for most people. |