| Summary: | kde-misc/kdocker-4.5 desktop icon isn't installed properly | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Agostino Sarubbo <ago> |
| Component: | [OLD] KDE | Assignee: | Gentoo KDE team <kde> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
Screenshot
Fix icon location patch |
||
|
Description
Agostino Sarubbo
2011-03-02 15:23:18 UTC
Created attachment 264363 [details]
Screenshot
Qt: 4.7.1 KDE Development Platform: 4.6.00 (4.6.0) did you try kbuildsycoca4? (In reply to comment #3) > did you try kbuildsycoca4? > yes..nothing to do next step is to check its .desktop file and icon ok, from qlist i see: /usr/share/kdocker/icons/kdocker.png a workaround is putting into kdocker a complete path of kdocker png: #Icon=kdocker Icon=/usr/share/kdocker/icons/kdocker.png works here with this method doesn't seem like a proper fix. my guess is that either the installation dir (/usr/share/kdocker/...) is wrong or that the desktop file doesn't search in that dir while it should Does this work in kde-4.6.3 ? (In reply to comment #8) > Does this work in kde-4.6.3 ? atm i can't test on 4.6.3 but on 4.6.2 does not work I am the upstream developer for KDocker. The kdocker.png should be installed into /usr/share/icons and the line in the .desktop file should say kdocker.png. This is an error with the upstream source. I will be correcting it shortly. However, fixing this issue does not make it into the just released 4.6 release of KDocker. Also, I do not see this as severe enough of an issue to warrant a special release with just this fix. Releases of KDocker are typically around every 6 months (it's a stable and feature complete project so there isn't much activity other than fixing bugs) so I would suggest this be fixed in the ebuild until it is included in KDocker 4.7. Actually the more I think about it. It shouldn't have .png on the icon line. Also, It would be better to put it in /usr/share/pixmaps instead of /usr/share/icons. Created attachment 275313 [details, diff]
Fix icon location patch
Here is a patch against revision 104 that puts the icon in /usr/share/pixmaps. This patch should revolve this issue.
thanks jonh It works for me. @kde team Please write on CVS and close as fixed =) Ty (In reply to comment #13) > thanks jonh > > It works for me. > > @kde team > Please write on CVS and close as fixed =) > > Ty And bump 4.6 :) Fixed in 4.6-r1, thanks! |