Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 356467

Summary: New ebuild: app-admin/eselect-php-0.6.2
Product: Gentoo/Alt Reporter: nietonfir
Component: Prefix SupportAssignee: Gentoo Prefix <prefix>
Status: RESOLVED OBSOLETE    
Severity: normal CC: cnyegle, php-bugs
Priority: High    
Version: unspecified   
Hardware: All   
OS: OS X   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 356465, 383159    
Attachments: prefixed eselect-php ebuild
eprefixifiy absolute paths
eprefixifiy absolute paths
prefixed eselect-php ebuild
prepend ${EPREFIX} now to all absolute paths
eselect-php-0.6.2-prefix.patch
ebuild uses now eprefixify
eprefixified eselect-php source patch

Description nietonfir 2011-02-25 19:25:37 UTC
The php team switched from app-admin/php-toolkit to app-admin/eselect-php. It's now a dependency for both dev-lang/php-5.3.3-r1 and dev-lang/php-5.3.5.

The following comments contain the ebuild and a patch to eprefixify absolute paths in the eselect module.
Comment 1 nietonfir 2011-02-25 19:28:54 UTC
Created attachment 263831 [details]
prefixed eselect-php ebuild
Comment 2 nietonfir 2011-02-25 19:29:34 UTC
Created attachment 263833 [details]
eprefixifiy absolute paths
Comment 3 nietonfir 2011-02-25 19:30:03 UTC
Created attachment 263835 [details, diff]
eprefixifiy absolute paths
Comment 4 Jonathan Callen (RETIRED) gentoo-dev 2011-02-26 02:28:06 UTC
You should not need to ever run eprefixify on a eselect module: eselect has built-in support for the EROOT and EPREFIX variables, so just use them, please.
Comment 5 nietonfir 2011-02-26 17:56:20 UTC
Created attachment 263951 [details]
prefixed eselect-php ebuild

(In reply to comment #4)
> You should not need to ever run eprefixify on a eselect module: eselect has
> built-in support for the EROOT and EPREFIX variables, so just use them, please.
> 
Thx for the information, applied the changes accordingly (after looking at eselect-vi :P ).
Comment 6 nietonfir 2011-02-26 17:57:26 UTC
Created attachment 263953 [details, diff]
prepend ${EPREFIX} now to all absolute paths
Comment 7 Fabian Groffen gentoo-dev 2011-02-27 09:48:06 UTC
Created attachment 264023 [details, diff]
eselect-php-0.6.2-prefix.patch

I redid your patch without having get_libdir to return the prefix for cleanness
Comment 8 Fabian Groffen gentoo-dev 2011-02-27 09:48:54 UTC
@php-bugs: please consider the eselect-php-0.6.2-prefix.patch attached to this bug for inclusion.
Comment 9 Ole Markus With (RETIRED) gentoo-dev 2011-02-27 10:27:16 UTC
Looks good. I'll create a release shortly.
Comment 10 Ole Markus With (RETIRED) gentoo-dev 2011-02-28 12:35:45 UTC
I just committed a new version of eselect-php with something like the attached patch.
Comment 11 nietonfir 2011-10-22 22:09:49 UTC
Created attachment 290567 [details]
ebuild uses now eprefixify

This goes hand in hand with the new (and a little bit improved) eselect-php-0.6.2-prefix.patch
Comment 12 nietonfir 2011-10-22 22:14:11 UTC
Created attachment 290569 [details, diff]
eprefixified eselect-php source patch

Instead of cluttering the installed eselect file with ${EPREFIX}, eprefixify will be used resulting in more cleaner paths. I was told that on another occasion that this is the preferred way. I'd obsolete Fabian Groffen patch but i'm unable to… ;)

And please add this tickets contents to the tree! ;)
Comment 13 nietonfir 2011-10-22 22:23:12 UTC
Okay, forget it, just saw the changes in eselect-php-0.6.6 making this bug obsolete. Everything works like a charm! Thanks for everything! ;)