Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 35453

Summary: ebuild for alternate spc plugin for xmms?
Product: Gentoo Linux Reporter: Andreas Eriksson <andreas>
Component: New packagesAssignee: Jeremy Huddleston (RETIRED) <eradicator>
Severity: normal CC: sound
Priority: High    
Version: unspecified   
Hardware: All   
OS: All   
Package list:
Runtime testing required: ---
Attachments: snesamp-xmms-cvs ebuiild

Description Andreas Eriksson 2003-12-09 08:50:00 UTC
the current xmms-spc that exists is horrible. the timing support is bad, and you can't see how long it takes for a song to finish with the normal time window or "progress bar". and it sounds horrible compared to the real snes.

This is a port for xmms from snesamp for winamp:

It fixes the timing problems, and you can see how long it takes for a song to finish with the normal ways, and, the sound quality is MUCH better than the current one. its only in cvs, and it doesn't look like there will be a release anytime soon, so I think an ebuild for this should be made and added to portage, so you can listen to SPC's the way they are meant to sound like.
If you want to compare here is an archive with lots of song:
Comment 1 Andreas Eriksson 2003-12-10 08:38:35 UTC
Created attachment 21976 [details]
snesamp-xmms-cvs ebuiild

I made an ebuild that does it. This is my first ebuild so please tell me if I
did anything wrong, so I can do it better next time.
Comment 2 Jeremy Huddleston (RETIRED) gentoo-dev 2004-01-31 22:57:10 UTC
we prefer not adding in ebuilds that pll directly from cvs.  It is preferable to take a snapshot of cvs when it is stable and provide that in the SRC_URI.

And since you wanted ebuild critiques... here's some things I would change (most of these are very common mistakes, so you did a good job with your first ebuild... especially since you figured out how to use the cvs eclass):

DEPEND should hold everything needed to compile/install the package, and RDEPEND should hold what is neccessary to run it.  By default, RDEPEND is set to be the same as DEPEND.  So I would change the DEPEND line to this:



Note that media-sound/xmms pulls depends on glib/gtk, so you don't need to add it here.

As for the src_install stuff... I'd use the do* commands rather than cp, chmod, etc... check out 'man 5 ebuild' and look for 'doexe'
Comment 3 Andreas Eriksson 2004-02-01 05:19:36 UTC
Thanks for your comments. I found a plugin that is better than this one and doesn't use cvs. I'm going to write an ebuild for that plugin instead when I get time.
Comment 4 Jeremy Huddleston (RETIRED) gentoo-dev 2004-02-08 02:36:16 UTC
ok... just open a new bug when you have the ebuild for the other package...