Summary: | ebuild for alternate spc plugin for xmms? | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Andreas Eriksson <andreas> |
Component: | New packages | Assignee: | Jeremy Huddleston (RETIRED) <eradicator> |
Status: | RESOLVED WONTFIX | ||
Severity: | normal | CC: | sound |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
URL: | http://snesamp-xmms.sourceforge.net/ | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | snesamp-xmms-cvs ebuiild |
Description
Andreas Eriksson
2003-12-09 08:50:00 UTC
Created attachment 21976 [details]
snesamp-xmms-cvs ebuiild
I made an ebuild that does it. This is my first ebuild so please tell me if I
did anything wrong, so I can do it better next time.
we prefer not adding in ebuilds that pll directly from cvs. It is preferable to take a snapshot of cvs when it is stable and provide that in the SRC_URI. And since you wanted ebuild critiques... here's some things I would change (most of these are very common mistakes, so you did a good job with your first ebuild... especially since you figured out how to use the cvs eclass): DEPEND should hold everything needed to compile/install the package, and RDEPEND should hold what is neccessary to run it. By default, RDEPEND is set to be the same as DEPEND. So I would change the DEPEND line to this: RDEPEND="media-sound/xmms" DEPEND="${RDEPEND} dev-util/cvs dev-lang/nasm" Note that media-sound/xmms pulls depends on glib/gtk, so you don't need to add it here. As for the src_install stuff... I'd use the do* commands rather than cp, chmod, etc... check out 'man 5 ebuild' and look for 'doexe' Thanks for your comments. I found a plugin that is better than this one and doesn't use cvs. I'm going to write an ebuild for that plugin instead when I get time. http://www.xmms.org/plugins.php?details=225# ok... just open a new bug when you have the ebuild for the other package... |