Bug 354087 – app-pda/syncevolution fails to build

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Diego Elio Pettenò (RETIRED) 2011-02-08 14:49:21 UTC]

Portage 2.1.9.38 (default/linux/x86/10.0, gcc-4.5.2-asneeded, glibc-2.13-r0, 2.6.37 i686)
=================================================================
System uname: Linux-2.6.37-i686-Quad-Core_AMD_Opteron-tm-_Processor_2350-with-gentoo-2.0.1
Timestamp of tree: Tue, 08 Feb 2011 13:30:01 +0000
app-shells/bash:     4.1_p9
dev-java/java-config: 2.1.11-r3
dev-lang/python:     2.7.1, 3.1.3
dev-util/cmake:      2.8.3-r1
sys-apps/baselayout: 2.0.1-r1
sys-apps/openrc:     0.7.0
sys-apps/sandbox:    2.4
sys-devel/autoconf:  2.13, 2.68
sys-devel/automake:  1.9.6-r3, 1.10.3, 1.11.1
sys-devel/binutils:  2.21
sys-devel/gcc:       4.5.2
sys-devel/gcc-config: 1.4.1
sys-devel/libtool:   2.4-r1
sys-devel/make:      3.82
virtual/os-headers:  2.6.36.1 (sys-kernel/linux-headers)
ACCEPT_KEYWORDS="x86 ~x86"
ACCEPT_LICENSE="*"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/eselect/postgresql /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -pipe"
DISTDIR="/var/cache/portage/distfiles"
FEATURES="assume-digests binpkg-logs distlocks fixlafiles fixpackages news parallel-fetch protect-owned sandbox sfperms split-log strict test test-fail-continue unknown-features-warn unmerge-orphans userfetch userpriv usersandbox"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://gentoo.wheel.sk/"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu"
MAKEOPTS="-j14"
PKGDIR="/var/spool/portage/packages"
PORTAGE_COMPRESS=""
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/var/cache/portage/tree"
SYNC="rsync://yamato.home.flameeyes.eu/gentoo-portage"
USE="acl berkdb bzip2 cli cracklib crypt cups cxx dri fortran gdbm gpm iconv ipv6 java5 java6 modules mudflap mysql ncurses nls nostatic nptl nptlonly openmp pam pcre pcsc-lite perl postgres pppd python qt3support readline ruby session ssl sysfs tcpd unicode vhosts x86 xorg zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1 emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias auth_digest cgi" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" PHP_TARGETS="php5-3" RUBY_TARGETS="ruby18 jruby ruby19 ree18" USERLAND="GNU" VIDEO_CARDS="intel radeon nouveau vmware" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, LINGUAS, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, PORTDIR_OVERLAY

[Comment 1 Diego Elio Pettenò (RETIRED) 2011-02-08 14:50:23 UTC]

Created attachment 261831 [details]
Build log

[Comment 2 Olivier Crete (RETIRED) 2011-02-08 14:57:29 UTC]

which version of libnotify ?

[Comment 3 Samuli Suominen (RETIRED) 2011-02-08 15:16:09 UTC]

(In reply to comment #2)
> which version of libnotify ?
> 

"too few arguments to function ‘NotifyNotification* notify_notification_new" would suggest he has 0.4.x or 0.5.x and syncevolution upstream failed and only included support for 0.7.x.

[Comment 4 Diego Elio Pettenò (RETIRED) 2011-02-08 15:17:15 UTC]

This was baseline 0.5

[Comment 5 Samuli Suominen (RETIRED) 2011-02-08 15:18:53 UTC]

OK, scratch that.   Let's try this again:

- NOTIFY_CHECK_VERSION was added in version 0.5.x
- notify_notification_new needs one more argument for 0.5.x

So this code is wrong:

#if !defined(NOTIFY_CHECK_VERSION)
    m_notification = notify_notification_new(summary, body, NULL, NULL);
#else // NOTIFY_CHECK_VERSION(0,7,0) is redundant, because 0.7.0 introduced
NOTIFY_CHECK_VERSION
    m_notification = notify_notification_new(summary, body, NULL);
#endif

That code makes it work only with 0.4.x or 0.7.x and it can't work with 0.5.x
which is current ~arch

[Comment 6 Samuli Suominen (RETIRED) 2011-02-08 15:23:53 UTC]

Created attachment 261839 [details, diff]
This works with all of 0.4.x 0.5.x and 0.7.x

Corrected upstream mistakes

[Comment 7 Samuli Suominen (RETIRED) 2011-02-08 15:32:36 UTC]

+  08 Feb 2011; Samuli Suominen <[e-mail]>
+  syncevolution-1.1.1.ebuild, +files/syncevolution-1.1.1-libnotify-0.5.x.patch:
+  Fix building with x11-libs/libnotify 0.5.x series wrt #354087 by Diego Elio
+  Pettenò.

[Comment 8 Olivier Crete (RETIRED) 2011-02-08 15:35:00 UTC]

Ugly patch alert! Can you please not put the #else inside the function call (just duplicate it)..

Then please send the patch upstream, thank you.. And you're welcome to add it to the ebuild.