Summary: | sys-apps/openrc-0.7.0: bridge.sh uses non-POSIX test operator "==" | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Christian <christian+bgo> |
Component: | [OLD] Core system | Assignee: | OpenRC Team <openrc> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | miska |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
patch for /lib/rc/net/bridge.sh
new patch |
Description
Christian
2011-01-29 11:55:41 UTC
Created attachment 260983 [details]
patch for /lib/rc/net/bridge.sh
Thanks to mv who pointed me to that file
I forgot: it's openrc-0.7.0 which is affected here. Comment on attachment 260983 [details] patch for /lib/rc/net/bridge.sh changing "==" to "=" is correct, but "-a" to "&&" is not. -a is clearly specified in POSIX: http://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html also, checkbasshisms throws too many false positives last i looked. you're right, -a/-o is defined, but && and || is also defined and so it isn't incorrect. I don't know much bout these things, I was only told that -a/-o isn't posix. But furthermore, -a/-o is marked with that, according to your document: Obsolescent The functionality described may be removed in a future version of this volume of POSIX.1-2008. Strictly Conforming POSIX Applications and Strictly Conforming XSI Applications shall not use obsolescent features. So, I dont't see the problem when using && and || instead of -a/-o whoever told you that is wrong. the obsolete aspect is irrelevant ... i highly doubt these are going anywhere considering it's the only way to test multiple things with a single `test` execution. at that point, you're just changing style, and that is frowned upon. fix what is incorrect (== -> =) and that's it. Created attachment 261121 [details, diff]
new patch
well, then here you go.
only changed == to =
(In reply to comment #6) > only changed == to = This patch looks good. Mike, what is your status on getting this into the tree? Thanks, William (In reply to comment #7) > (In reply to comment #6) > > only changed == to = > This patch looks good. > Mike, what is your status on getting this into the tree? I am thinking about spinning a new openrc release this weekend and I would like to see this and the makefile changes I sent to the alias as part of that release. Thanks, William This patch has been applied to git, commit 43678fd. Christian, thanks for the report and the patch. *** Bug 357729 has been marked as a duplicate of this bug. *** |