| Summary: | sys-apps/mlocate-0.23.1: syntax error in /etc/cron.daily/mlocate | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Christian Seiler <chris_se> |
| Component: | New packages | Assignee: | Tomáš Chvátal (RETIRED) <scarabeus> |
| Status: | RESOLVED FIXED | ||
| Severity: | critical | CC: | base-system, fauli, gentoo |
| Priority: | High | Keywords: | InVCS |
| Version: | unspecified | ||
| Hardware: | AMD64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
If anyone else also struggles for a moment to find the difference: The first if-block misses the ending 'fi' Increasing severity, because this is an ubiquitous package, and the breakage affects the stable version. I am really sorry for such typo :/ +*mlocate-0.23.1-r1 (30 Jan 2011) + + 30 Jan 2011; Tomáš Chvátal <scarabeus@gentoo.org> -mlocate-0.22.4.ebuild, + -mlocate-0.23.1.ebuild, +mlocate-0.23.1-r1.ebuild, files/mlocate.cron-r2: + Revision bump with perserved stable keywords. Fix typo in cronfile that + prevented cronjob to operate per bug #353122. Drop older affected version to + ensure everyone upgrade. + Btw ad the criticalness i am not particulary sure it is this high (you can always regen the db by hand or use locate). Anyway mea culpa maxima and sorry for not spotting it. |
There is a syntax error in /etc/cron.daily/mlocate that is installed with the package sys-apps/mlocate-0.23.1; there is a "fi" missing in line 38. Reproducible: Always Steps to Reproduce: 1. Install sys-apps/mlocate-0.23.1 on a fresh system 2. Wait until midnight until the cronjob is run -or- directly run /etc/cron.daily/mlocate as root Actual Results: - "Syntax error" on execution of cron.daily script - "locate foo" does not work, because no database is ever generated Expected Results: updatedb is run Installed script: -------------------------------------------------------------------- if [ -x /usr/bin/renice ]; then /usr/bin/renice +${NICE:-19} -p $$ > /dev/null 2>&1 if [ -x /usr/bin/ionice ] && /usr/bin/ionice -c3 true 2>/dev/null; then /usr/bin/ionice -c${IONICE_CLASS:-2} -n${IONICE_PRIORITY:-7} -p $$ > /dev/null 2>&1 fi -------------------------------------------------------------------- Correct version would be: -------------------------------------------------------------------- if [ -x /usr/bin/renice ]; then /usr/bin/renice +${NICE:-19} -p $$ > /dev/null 2>&1 fi if [ -x /usr/bin/ionice ] && /usr/bin/ionice -c3 true 2>/dev/null; then /usr/bin/ionice -c${IONICE_CLASS:-2} -n${IONICE_PRIORITY:-7} -p $$ > /dev/null 2>&1 fi --------------------------------------------------------------------