Bug 352291 – dev-vcs/gitolite-gentoo-1.5.8.1-r1 ; doesn't install correclty, if gitosis was installed before

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Enno Gröper 2011-01-20 21:53:34 UTC]

Because the user git doesn't get deleted when removing (emerge -C) gitosis, it doesn't get created when installing gitolite.
Of course this is difficult, but at least a warning should be issued, if the user can't be created. I'm pretty sure gitolite doesn't work without gits home directory set to /var/lib/gitolite.

Reproducible: Always

Steps to Reproduce:
1. emerge gitosis
2. emerge -C gitosis
3. emerge gitolite-gentoo

Actual Results:  
cat /etc/passwd | grep git
git:x:101:1002:added by portage for gitosis:/var/spool/gitosis:/bin/sh

Expected Results:  
cat /etc/passwd | grep git
git:x:101:110:added by portage for gitolite-gentoo:/var/lib/gitolite:/bin/bash

[Comment 1 Christian Ruppert (idl0r) 2011-01-23 00:04:50 UTC]

Fixed in CVS, thanks :)

[Comment 2 Jeremy Olexa (darkside) (RETIRED) 2011-02-03 04:29:59 UTC]

Instead of adding a warning[1], why don't you just change the HOME directly? (There is a precedent for this in net-misc/openntpd-3.9_p1-r2)

[1]: http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/dev-vcs/gitolite-gentoo/gitolite-gentoo-1.5.8.1-r1.ebuild?r1=1.1&r2=1.2

[Comment 3 Christian Ruppert (idl0r) 2011-02-03 14:11:30 UTC]

(In reply to comment #2)
> Instead of adding a warning[1], why don't you just change the HOME directly?
> (There is a precedent for this in net-misc/openntpd-3.9_p1-r2)
> 
> [1]:
> http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/dev-vcs/gitolite-gentoo/gitolite-gentoo-1.5.8.1-r1.ebuild?r1=1.1&r2=1.2
> 

I'm not sure if I would like that..
Example: You're still using gitosis (prod.) and you install gitolite because you plan to migrate and you want to prepare everything first. It would cause trouble because gitosis's HOME would be different from now on.