Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 351906

Summary: sys-kernel/genkernel-3.4.11 does not honor --kernel-config
Product: Gentoo Linux Reporter: Donald R. Gray Jr <donald.r.gray>
Component: Current packagesAssignee: Gentoo Genkernel Maintainers <genkernel>
Status: RESOLVED FIXED    
Severity: normal CC: email, gbugs, kanelxake, sping
Priority: High Keywords: InVCS
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Donald R. Gray Jr 2011-01-17 13:32:24 UTC
When running genkernel with --kernel-config my config is not imported, works fine under 3.4.10.908.

Reproducible: Always

Steps to Reproduce:
Run gunkernel with --kernel-config
Check processor type is generic-x86_64, when config is core2. 
Compression type is gzip when config is LZMA.

Many other options are missing as well.
Comment 1 Toei Rei 2011-01-18 10:48:46 UTC
Same problem here - it ignores old kernel configs in /etc/kernels even if it pretends to be using it.
Comment 2 Jürgen Geuter 2011-01-18 19:29:00 UTC
I had the same problem, but it only occured when the kernel I wanted to build had not been build sucessfully before (so if I used the --kernel-config switch to initialize a -r bump for my Kernel). After falling back to an older genkernel version, building the kernel successfully and upgrading genkernel, things worked out.
Comment 3 Sebastian Pipping gentoo-dev 2011-01-19 01:04:10 UTC
I suppose this commit is guilty somehow:
http://git.overlays.gentoo.org/gitweb/?p=proj/genkernel.git;a=commitdiff;h=dfddd742bda34ceea56b494675ca17754c8bdff2

If you spot the problem before me (no time yet), please share your insight with me.
Comment 4 Fernando (likewhoa) 2011-01-19 03:29:39 UTC
same issue here
Comment 5 Fernando (likewhoa) 2011-01-19 04:11:10 UTC
(In reply to comment #3)
> I suppose this commit is guilty somehow:
> http://git.overlays.gentoo.org/gitweb/?p=proj/genkernel.git;a=commitdiff;h=dfddd742bda34ceea56b494675ca17754c8bdff2
> 
> If you spot the problem before me (no time yet), please share your insight with
> me.
> 

I don't think that commit is the cause of this since I tried to roll back to previous method with same results and since I am pressed for time i can't really dig further into this. 
Comment 6 Xake 2011-01-19 19:40:05 UTC
@sping

The problem here is that you moved the whole copying of kernel config.
Before genkernel did "make clean" (which also removes the .config file) and then copied the specified config file into place.

After your  change the config file is copied into place, then genkernel runs "make clean" which removes it, leaving a non-existent .config for the rest of the make process...
Comment 7 Xake 2011-01-19 19:44:52 UTC
(In reply to comment #6)

Forgot to say that a fast way to indeed determine this is to move line 42 (cp "${KERNEL_CONFIG}" "${KERNEL_DIR}/.config" || gen_die 'Could not copy configuration file!') to line 66 (directly after make clean code snippet) and it will work nice.

Comment 8 Sebastian Pipping gentoo-dev 2011-01-20 01:42:03 UTC
Xake, thanks for investigating.  "make clean" was a good hint, but in my testing (with 2.6.36-gentoo-r4) I found that "make clean" keeps .config, while "make mrproper" deletes it.

It may be fixed by now.  You can test the new code like this:

  # git clone git://git.overlays.gentoo.org/proj/genkernel.git
  # git checkout -t origin/bug-351906
  # sudo GK_SHARE="$PWD" ./genkernel kernel

The most interesting patch on branch "bug-351906" is this:

http://git.overlays.gentoo.org/gitweb/?p=proj/genkernel.git;a=commitdiff;h=9c2d3acc7e4612d50046ff42e9a30a8c1d5f42fb

Please report how it works for you.
Comment 9 Donald R. Gray Jr 2011-01-20 03:19:26 UTC
(In reply to comment #8)
> Xake, thanks for investigating.  "make clean" was a good hint, but in my
> testing (with 2.6.36-gentoo-r4) I found that "make clean" keeps .config, while
> "make mrproper" deletes it.
> 
> It may be fixed by now.  You can test the new code like this:
> 
>   # git clone git://git.overlays.gentoo.org/proj/genkernel.git
>   # git checkout -t origin/bug-351906
>   # sudo GK_SHARE="$PWD" ./genkernel kernel
> 
> The most interesting patch on branch "bug-351906" is this:
> 
> http://git.overlays.gentoo.org/gitweb/?p=proj/genkernel.git;a=commitdiff;h=9c2d3acc7e4612d50046ff42e9a30a8c1d5f42fb
> 
> Please report how it works for you.
> 

That branch works fine here.
Comment 10 Donald R. Gray Jr 2011-01-20 03:22:32 UTC
BTW running with the following options:

Running with options: all --menuconfig --config=/etc/genkernel.conf --clean --mrproper --splash --install --symlink --all-ramdisk-modules --kernel-config=/etc/kernels/kernel-config-x86_64-2.6.37-gentoo --save-config --makeopts=-j4 --mountboot --splash=natural_gentoo --splash-res=1024x768 --disklabel --firmware --firmware-dir=/lib/firmware

Comment 11 Sebastian Pipping gentoo-dev 2011-01-20 14:37:14 UTC
(In reply to comment #10)
> BTW running with the following options:
> 
> Running with options: all --menuconfig --config=/etc/genkernel.conf --clean
> --mrproper --splash --install --symlink --all-ramdisk-modules
> --kernel-config=/etc/kernels/kernel-config-x86_64-2.6.37-gentoo --save-config
> --makeopts=-j4 --mountboot --splash=natural_gentoo --splash-res=1024x768
> --disklabel --firmware --firmware-dir=/lib/firmware

FYI most (if not all) of that can be move to genkernel.conf, if you run more or less the same command every time.

New release 3.4.11.1 just hit the Gentoo tree.

+*genkernel-3.4.11.1 (20 Jan 2011)
+
+  20 Jan 2011; Sebastian Pipping <sping@gentoo.org> -genkernel-3.4.11.ebuild,
+  +genkernel-3.4.11.1.ebuild:
+  Bump to 3.4.11.1. Closes bug #351906 and #351909
+