Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 351887

Summary: app-cdr/cdemud-1.3.0 - /etc/conf.d/cdemud could be more explicit about "pulse" option in a comment, please
Product: Gentoo Linux Reporter: Alexey Shildyakov <ashl1future>
Component: New packagesAssignee: Alexandre Rostovtsev (RETIRED) <tetromino>
Status: RESOLVED OBSOLETE    
Severity: minor    
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Alexey Shildyakov 2011-01-17 07:40:00 UTC
In /etc/conf.d/cdemud I see:
# You can use all backends libao has been built with.
# This includes for example: (<audio system> -> <driver name>)
#   pulseaudio -> pulse
#   alsa -> alsa
So, I write: CDEMUD_AUDIO_DRIVER="pulseaudio -> pulse"

With this /etc/init.d/cdemud won't start. With this option's value it starts only if use quoted ${CDEMUD_AUDIO_DRIVER} value:
        start-stop-daemon --quiet --start \
                --exec /usr/bin/cdemud -- \
                -d -c /dev/vhba_ctl -n ${CDEMUD_DEVICES} -a "${CDEMUD_AUDIO_DRIVER}"

If I change CDEMUD_AUDIO_DRIVER="pulse", it starts without quoted value.

In cdemud's man I see:
-a --audio-driver=driver
... Few examples of valid libao drivers are alsa, oss, pulse or null. ...

So, there are 2 solution:
1. Use quoted value in /etc/init.d/cdemud
2. Change comments in /etc/conf.d/cdemud to use simple audio drivers name - just only "pulse" instead of "pulseaudio -> pulse"
Comment 1 Rafał Mużyło 2011-01-17 11:41:24 UTC
Upgrade your processing unit - that reads clearly as "for <souund system type> set CDEMUD_AUDIO_DRIVER to <value>".
Comment 2 Alexey Shildyakov 2011-01-17 16:11:07 UTC
If you means my brain by "my processing unit", it will not clear. It's written:

for example:
pulseaudio -> pulse

You shouldn't write in example anything that is not real value.
Instead of that you should write text like this:

# For example, for audio system "pulseaudio" you should write "pulse",
# for "alsa" should write "alsa".
#CDEMUD_AUDIO_DRIVER="pulse"

or this:

#You should write driver name for CDEMUD_AUDIO_DRIVER from the following list:
#   <audio system> -> <driver name>
#   pulseaudio -> pulse
#   alsa -> alsa
#CDEMUD_AUDIO_DRIVER="pulse"

Main idea is using commented real example: #CDEMUD_AUDIO_DRIVER="pulse".
Comment 3 Rafał Mużyło 2011-01-17 23:59:31 UTC
Honestly, there are 2 valid choices by now alsa and pulse (as oss was disabled and I doubt anyone is still seriously using nas).

That this is a mapping is quite clear for me.
Comment 4 Alexey Shildyakov 2011-01-18 00:06:40 UTC
Ok.
If my intentions above are clear for you and clear for me it will be clear for more people than compared with old comments. And I think one added string #CDEMUD_AUDIO_DRIVER="pulse" will increase option understanding compared with prior.
So, is my intention so hard to realize? 
Comment 5 Alexandre Rostovtsev (RETIRED) gentoo-dev 2011-11-23 10:20:19 UTC
Starting with version 1.4.0, cdemud no longer installs /etc/conf.d/cdemud and /etc/init.d/cdemud.