Summary: | media-libs/libquicktime-1.2.2 poor programming practices lead to failure | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Ingo Krabbe <ikrabbe.ask> |
Component: | Current packages | Assignee: | Gentoo Media-video project <media-video> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | buraktuysuz, creffett, esqualante, JakesAddress, phajdan.jr, staff, stian.jenssen, zioalex |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | 380169 | ||
Bug Blocks: | |||
Attachments: |
Patch to remove deprecation warning when compiling against new gtk libraries
libquicktime-1.2.2-r1.ebuild lqt_gtk.c.diff |
Description
Ingo Krabbe
2011-01-16 16:07:34 UTC
Created attachment 260012 [details, diff]
Patch to remove deprecation warning when compiling against new gtk libraries
utils/gtk/lqt_gtk.c
changed gtk_combo_box_new_text into gtk_combo_box_text_new as proposed by gtk documentation.
The patch makes the package compile. Please test against older/stable gtk+ and merge the patch file to the portage tree. (In reply to comment #2) > The patch makes the package compile. Please test against older/stable gtk+ and > merge the patch file to the portage tree. After you closed this bug it is unlikely the maintainers will look at it. If you want someone to take action, please re-open. That was a bit fast, please still review and fix the ebuild. I just wanted to express that the patch works-for-me. please send that patch upstream first *** Bug 361213 has been marked as a duplicate of this bug. *** It still fails with the same error. Please apply the patch upstream. Created attachment 268381 [details]
libquicktime-1.2.2-r1.ebuild
Added the patch to the ebuild, renamed the patch to lqt_gtk.c.diff.
Created attachment 268383 [details]
lqt_gtk.c.diff
Renamed patch
The above patch works well. Is there anything else that is holding up the merge of this fix, to the main Gentoo tree? Whenever I do "emerge --sync", it becomes broken again, and I must remember to copy in the files again and run "ebuild digest" on it. The libquicktime-1.2.2-r1 version cleanly builds. why not use overlay, until it is fixed in main tree? This bug is breaking my revdep-rebuild every time. Any timeline on getting it into the main trunk? I had the same problem and this updated ebuild and patch resolved it for me. Is this going into main portage soon? Instead of waiting for a fix one can also use the newer media-libs/libquicktime-1.2.3. This works fine on my systems, no complaints about poor programming practices any more. Currently it is marked as ~amd64. In order to use it, try with echo "=media-libs/libquicktime-1.2.3 ~amd64" >> /etc/portage/package.keywords followed by e.g. emerge -1 libquicktime confirmig, libquicktime-1.2.3 solves the issue described here. Can we get stabilization of libquicktime-1.2.3 for the 64 Bit archs? I can confirm as well, though building without the "gtk" USE flag compiles successfully. Comment on attachment 268383 [details]
lqt_gtk.c.diff
Verified this patch is part of upstream 1.2.4 release.
1.2.4 in Portage and solves this bug |