Bug 351709 – genkernel should support real_root=UUID/LABEL=*

• Product: Gentoo Linux
• Status: RESOLVED INVALID

[Description Richard Freeman 2011-01-14 22:42:37 UTC]

The genkernel initrd init script includes support for parsing UUID/LABEL=* for REAL_RESUME, but it does not support this for REAL_ROOT.

In theory a few lines of code should be able to add this support for REAL_ROOT.  Identifying a filesystem by UUID is a good practice that many other distros currently support.

I do not have a patch at this point - if I get some time I might work on one.

[Comment 1 Sebastian Pipping 2011-01-15 16:20:50 UTC]

Hello!  If I'm not mistaken, this feature is supported in the latest stable release already.  Do you have either of

 a) DISKLABEL="yes" in genkernel.conf or
 b) --disklabel appended to the invocation of genkernel?

From the code point of view it should be working:

# fgrep -iR real_resume .
[..]
./defaults/linuxrc:  RESUME_DEV=`findfs "${REAL_RESUME}" 2>/dev/null`
./defaults/linuxrc:  RESUME_DEV=`busybox findfs "${REAL_RESUME}" 2>/dev/null`
./defaults/linuxrc:  RESUME_DEV=`blkid -t "${REAL_RESUME}" | cut -d ":" -f 1 2>/dev/null`
[..]

If it doesn't work with stable, please try genkernel-99999 (five nines) instead, though I don't expect that to be necessary here.

Please report back, how it works out.
If I do not hear anything in two weeks, I may close this bug.

[Comment 2 Richard Freeman 2011-01-15 16:30:40 UTC]

(In reply to comment #1)
>  a) DISKLABEL="yes" in genkernel.conf or

yes

> 
> From the code point of view it should be working:
> 
> # fgrep -iR real_resume .

Try fgrep -iR real_root .

This bug isn't about REAL_RESUME - it was just for comparison.

[Comment 3 Sebastian Pipping 2011-01-15 17:14:35 UTC]

(In reply to comment #2)
> Try fgrep -iR real_root .
> This bug isn't about REAL_RESUME - it was just for comparison.

Right, sorry.

Still, there's similar code in for real_root:

# fgrep -iR real_root .
[..]
./defaults/linuxrc:  ROOT_DEV=`findfs "${REAL_ROOT}" 2>/dev/null`
./defaults/linuxrc:  ROOT_DEV=`busybox findfs "${REAL_ROOT}" 2>/dev/null`
./defaults/linuxrc:  ROOT_DEV=`blkid -l -t "${REAL_ROOT}" | cut -d ":" -f 1 2>/dev/null`
[..]

Any ideas?

[Comment 4 Richard Freeman 2011-01-16 03:30:22 UTC]

Whoops - must have somehow been using an older version when I did the build.  I agree, it is in there.  

Still won't work for me until mdadm is included, but that is already covered by another bug.  closing, and sorry for the noise...