Bug 351534

Summary:	Installation layout for dev-util/biew-6.1.0 needs cleanup
Product:	Gentoo Linux	Reporter:	Nico R. <n-roeser>
Component:	[OLD] Development	Assignee:	Kevin McCarthy (RETIRED) <signals>
Status:	RESOLVED FIXED
Severity:	normal	CC:	signals
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Cleaned up EAPI=4 build Misc fixes. Changes the test constructs in the configure script to working and portable ones.

Description Nico R. 2011-01-13 11:37:10 UTC

When biew-6.1.0 was added (see bug 305809), some problems appeared (again). At least some of these had already been solved for biew-5.7.0 (see bug 255835):

* man page is installed twice (into /usr/man/ and /usr/share/man/),
* other files are installed as /usr/share/* instead of /usr/share/biew/*,
* the configure script has a bug: in the output, the following line appears when using the de_DE.UTF-8 locale:
./configure: Zeile 581: test: Zu viele Argumente.

(That’s “too many arguments” in English. The configure script should not use ‘test … -o …’, but ‘test … || test …’, I think. IIRC, the autoconf manual has some info on things like these.)

Looks like the configure script and the makefile could do with some patching. Probably things from bug 255835 can be reused or ported to biew-6.1.0.

Comment 1 Michał Górny archtester

2011-01-16 10:48:55 UTC

This package is unmaintained at the moment, we'll be happy to fix it for you if you submitted patches.

Comment 2 Kevin McCarthy (RETIRED) gentoo-dev

2011-02-04 03:12:40 UTC

Created attachment 261471 [details]
Cleaned up EAPI=4 build

Fixes man location problem and data location problem. 
General Cleanup.

Comment 3 Kevin McCarthy (RETIRED) gentoo-dev

2011-02-04 03:16:28 UTC

I was unable to duplicate the configure error with my locale set to de_DE.UTF-8, so please try the attached ebuild and comment on this bug if you are still seeing the issue.

Thanks.

Comment 4 Kevin McCarthy (RETIRED) gentoo-dev

2011-02-04 16:49:06 UTC

Created attachment 261520 [details]
Misc fixes.

General cleanup:

Moved makefile edit to src_prepare()
Call die on external commands
Simplified SRC_URI
Call ./configure instead of econf
Remove eutils eclass
Syntax cleanup

Comment 5 Kevin McCarthy (RETIRED) gentoo-dev

2011-02-04 16:57:09 UTC

Note: since this new ebuild puts the data files in the proper place, you will probably have to edit the paths in biew's setup dialog. Alternatively, you can just delete ~/.biewrc and let biew find its files on its own.

Comment 6 Kevin McCarthy (RETIRED) gentoo-dev

2011-02-23 16:29:13 UTC

dev-util/biew-6.1.0-r1 is now in portage.

Comment 7 Nico R. 2011-02-24 11:12:14 UTC

Created attachment 263675 [details, diff]
Changes the test constructs in the configure script to working and portable ones.

In reply to comment 3 by Kevin:
> I was unable to duplicate the configure error with my locale set to
> de_DE.UTF-8, so please try the attached ebuild and comment on this bug if you
> are still seeing the issue.

This seems to happen when debugging is enabled. This patch changes the problematic parts of the configure script.

Upstream has completely revamped the configure script, so I have not sent this patch upstream.

See bug 321963 comment 14 for a patch to the ebuild file adding this patch (and the one for that bug).

Comment 8 Nico R. 2011-02-24 11:16:06 UTC

Reopening this bug to allow tracking the status of the patch mentioned in comment 7.

Comment 9 Kevin McCarthy (RETIRED) gentoo-dev

2011-02-24 14:20:25 UTC

Thanks for the patches! I have committed them to portage. The current biew-6.1.0-r1 ebuild should have both of these patches applied. Please re-open this bug if you still have problems.