Bug 350616

Summary:	net-misc/openssh /proc/self/oom_adj needs to use /proc/self/oom_score_adj
Product:	Gentoo Linux	Reporter:	Donald R. Gray Jr <donald.r.gray>
Component:	[OLD] Core system	Assignee:	Gentoo's Team for Core System packages <base-system>
Status:	RESOLVED UPSTREAM
Severity:	trivial
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	https://bugzilla.mindrot.org/show_bug.cgi?id=1838
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	oomkill patch Updated ebuild

Description Donald R. Gray Jr 2011-01-05 01:25:15 UTC

sshd ($PID) /proc/$PID/oom_adj is deprecated, please use /proc/$PID/oom_score_adj instead

Reproducible: Always

Comment 1 Donald R. Gray Jr 2011-01-05 01:30:10 UTC

Created attachment 258887 [details]
oomkill patch

Comment 2 Donald R. Gray Jr 2011-01-05 01:30:44 UTC

Created attachment 258888 [details]
Updated ebuild

Comment 3 Donald R. Gray Jr 2011-01-05 21:23:59 UTC

Patch is from upstream, submitting here since I modified the ebuild to test the patch on a 2.6.36 kernel for upstream.

Comment 4 SpanKY gentoo-dev

2011-01-08 22:06:59 UTC

your oom_adjust should be static and constant, and you should be using ARRAY_SIZE() instead of "2"

usually these sort of enhancements though go through the upstream project:
    https://bugzilla.mindrot.org/

it's not like the userspace abi is changing anytime soon here ...

Comment 5 SpanKY gentoo-dev

2011-01-08 22:07:47 UTC

err, i see you already did.  i'll post my feedback there.