| Summary: | net-misc/asterisk-1.8.1.1 & net-misc/asterisk-1.8.0 fail to install when MAKEOPTS has -j option with value >1 | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | rad0xicated |
| Component: | Current packages | Assignee: | Tony Vroon (RETIRED) <chainsaw> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | voip+disabled |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | x86 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | Patch file for the ebuild | ||
Created attachment 258607 [details, diff]
Patch file for the ebuild
No, this is not the correct fix. Please try the patchset on bug #344533 and report success/failure here. The Makefile isn't appropriately serialized, so the directory creation is not in front on the file installs. If we pre-create the directories, we can continue to do a parallel install. It installs when I apply the menuselect-deps-and-mkdir.patch as posted in bug #344533. Are you sure it's the safest way to go though? I would think -j1 for the install isn't that bad, but i'm not an expert at this. (In reply to comment #3) > It installs when I apply the menuselect-deps-and-mkdir.patch as posted in bug > #344533. Thank you. I will leave this report open until 1.8.1.1-r1 hits the tree. > Are you sure it's the safest way to go though? Yes, there is no difference between enforcing the correct order on the broken build system (making sure that the install statements that create the required directories go first) or pre-creating the directories in question so that copy statements can safely trigger before the directory creation statements. You are welcome to benchmark the two solutions against each other. What I suspect that you will find is that both methods (my pre-creation and your -j1) put the exact same amount of files on disk, but that mine is faster. How much faster depends on the amount of CPUs in the machine. +*asterisk-1.8.1.1-r1 (04 Jan 2011) + + 04 Jan 2011; Tony Vroon <chainsaw@gentoo.org> -asterisk-1.8.0.ebuild, + -asterisk-1.8.1.1.ebuild, +asterisk-1.8.1.1-r1.ebuild: + As pointed out by Ivan L. Isaev in bug #344533, MySQL was not fully enabled. + Together with Michael Lesniewski I have redone all conditional statements + through menuselect instead of through use_with. Pre-creating directories in + the installation image allows parallel install with MAKEOPTS above -j1, + closes bug #350339 by rad0xicated@gmail.com. Kill USE=logrotate which snuck + back in. Kill USE=keepsrc as I do not believe it is used. Petition me through + a bug report if you disagree and present a clear use case. Nuke older 1.8 + branch ebuilds, they are useless now because of a gtalk protocol change. I'm getting install errors again after adding srtp to the use flags. The use flags this occurred with are: caps gtalk iconv samples srtp ssl. MAKE_OPTS="-j4". The errors aren't occurring every emerge though. /usr/bin/install: cannot create directory `/var/tmp/portage/net-misc/asterisk-1.8.1.1-r1/image//var/lib/asterisk/images': File exists make: *** [installdirs] Error 1 That is a new bug on a different ebuild. Please do not reopen old bugs. File a new report instead. |
Summary explains all. Reproducible: Always Steps to Reproduce: 1. Set MAKEOPTS="-j4" in /etc/make.conf 2. Emerge =asterisk-1.8.1.1 (or 1.8.0 for that matter) Expected Results: To fix this, add -j1 to line 157 of asterisk-1.8.1.1.ebuild: 'emake DESTDIR="${D}" install || die "emake install failed"' => 'emake -j1 DESTDIR="${D}" install || die "emake install failed"' make -j4 DESTDIR=/var/tmp/portage/net-misc/asterisk-1.8.1.1/image/ install /usr/bin/install -c -d "/var/tmp/portage/net-misc/asterisk-1.8.1.1/image//usr/lib/asterisk/modules" /usr/bin/install: cannot create regular file `/var/tmp/portage/net-misc/asterisk-1.8.1.1/image//usr/sbin/astcanary': No such file or directory make[1]: *** [install] Error 1 make: *** [utils-install] Error 2 make: *** Waiting for unfinished jobs....