Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 350330

Summary: dev-vcs/git-1.7.3.4-r1: CVS automagically built, fails CVS testsuite with FEATURES=-userpriv USE=-cvs
Product: Gentoo Linux Reporter: Jeremy Murphy <jeremy.william.murphy>
Component: [OLD] DevelopmentAssignee: Robin Johnson <robbat2>
Status: VERIFIED FIXED    
Severity: normal CC: peter, ricmm
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: Fails testsuite on x86
t9200 test failure
t9200 test failure --verbose --no-color
Updated patch against current git.git master HEAD

Description Jeremy Murphy 2011-01-02 04:46:34 UTC
Failed 12 among 15 tests from 't9200-git-cvsexportcommit.sh'.

Reproducible: Always

Steps to Reproduce:
1. emerge =dev-vcs/git-1.7.3.4-r1




Portage 2.1.9.25 (default/linux/x86/10.0/desktop/kde, gcc-4.4.4, glibc-2.11.2-r3, 2.6.36-gentoo-r2 i686)
=================================================================
                        System Settings
=================================================================
System uname: Linux-2.6.36-gentoo-r2-i686-Intel-R-_Pentium-R-_M_processor_1.86GHz-with-gentoo-1.12.14
Timestamp of tree: Sat, 01 Jan 2011 22:15:01 +0000
distcc 3.1 i686-pc-linux-gnu [enabled]
app-shells/bash:     4.1_p7
dev-java/java-config: 2.1.11-r1
dev-lang/python:     2.6.6-r1, 3.1.2-r4
dev-util/cmake:      2.8.1-r2
sys-apps/baselayout: 1.12.14-r1
sys-apps/sandbox:    2.4
sys-devel/autoconf:  2.13, 2.65-r1
sys-devel/automake:  1.9.6-r3, 1.10.3, 1.11.1
sys-devel/binutils:  2.20.1-r1
sys-devel/gcc:       4.4.4-r2
sys-devel/gcc-config: 1.4.1
sys-devel/libtool:   2.2.10
sys-devel/make:      3.81-r2
virtual/os-headers:  2.6.30-r1 (sys-kernel/linux-headers)
ACCEPT_KEYWORDS="x86"
ACCEPT_LICENSE="* -@EULA skype-eula AdobeFlash-10.1 dlj-1.1"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -march=pentium-m -pipe -fomit-frame-pointer"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /var/lib/hsqldb"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/php/apache2-php5.3/ext-active/ /etc/php/cgi-php5.3/ext-active/ /etc/php/cli-php5.3/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -march=pentium-m -pipe -fomit-frame-pointer"
DISTDIR="/usr/portage/distfiles"
FEATURES="assume-digests binpkg-logs distcc distlocks fixlafiles fixpackages news parallel-fetch protect-owned sandbox sfperms strict test unknown-features-warn unmerge-logs unmerge-orphans userfetch"
GENTOO_MIRRORS="http://ftp.iinet.net.au/pub/Gentoo "
LANG="en_AU.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu"
LINGUAS="en_AU en_AU.UTF-8 en_GB en_GB.UTF-8"
MAKEOPTS="-j6"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/home"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/var/lib/layman/science /usr/local/portage"
SYNC="rsync://rsync.au.gentoo.org/gentoo-portage"
USE="X a52 aac aalib acpi alsa apache2 avahi bash-completion berkdb blas bluetooth branding bzip2 cairo cdda cddb cdr cli consolekit cracklib crypt cups curl cxx dbus djvu dri dts dv dvb dvd dvdr emboss encode exif expat fam ffmpeg fftw firefox flac fontconfig fortran gd gdbm gdu geoip gif gmp gnutls gphoto2 gpm graphviz gsl gtk iconv icu ieee1394 imagemagick imlib ipod ipv6 java java6 javascript jpeg kde kqemu lame lapack latex lcms ldap libsamplerate lirc lzo mad matroska mikmod mmap mmx mng modules mp3 mp4 mpeg mtp mudflap musepack mysql mysqli ncurses nls nptl nptlonly nsplugin odbc offensive ogg openal opengl pam pango pch pcre pdf perl php png policykit ppds pppd python qt3support qt4 readline recode samba sdl session sharedmem sndfile sockets spell sqlite sqlite3 sse sse2 ssl startup-notification subversion svg sysfs syslog sysvipc taglib tcpd theora threads tiff timidity truetype udev unicode usb vorbis wavpack wifi wmf wxwidgets x264 x86 xcb xcomposite xml xorg xpm xscreensaver xulrunner xv xvid zeroconf zlib" ALSA_CARDS="intel8x0" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="evdev synaptics" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="en_AU en_AU.UTF-8 en_GB en_GB.UTF-8" PHP_TARGETS="php5-3" RUBY_TARGETS="ruby18" USERLAND="GNU" VIDEO_CARDS="radeon" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account" 
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, FFLAGS, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 1 Jeremy Murphy 2011-01-02 04:48:34 UTC
Created attachment 258603 [details]
Fails testsuite on x86
Comment 2 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2011-01-03 05:04:43 UTC
Please re-run just test t9200 with --verbose --no-color, in non-parallel and attach the output here.
Comment 3 Jeremy Murphy 2011-01-03 05:34:31 UTC
(In reply to comment #2)
> Please re-run just test t9200 with --verbose --no-color, in non-parallel and
> attach the output here.
> 

Sure, but... how?  If I run t9200-git-cvsexportcommit.sh, I get an error about not having built things yet.
Comment 4 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2011-01-03 05:37:09 UTC
Run ebuild ... package with your identical FEATURES etc. When it bails out due to test failure, go into the test dir and run it manually.
Comment 5 Jeremy Murphy 2011-01-03 06:38:23 UTC
Hmmm, but shouldn't it already be in that state now, after the emerge failed?
Comment 6 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2011-01-04 23:07:58 UTC
It should work quite fine at that point.
Can you give me the actual output from trying to run it manually after the previous emerge command?
Comment 7 Jeremy Murphy 2011-01-06 13:08:09 UTC
(In reply to comment #6)
> It should work quite fine at that point.
> Can you give me the actual output from trying to run it manually after the
> previous emerge command?
> 

If I go into work/git-1.7.3.4 there is this:

# ./git-cvsexportcommit.perl 
Need at least one commit identifier! at ./git-cvsexportcommit.perl line 19.

and if I then go into work/git-1.7.3.4/t there is this:

# ./t9200-git-cvsexportcommit.sh 
error: You haven't built things yet, have you?
Comment 8 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2011-01-06 20:43:26 UTC
That's really weird.

Can you please retest with 1.7.3.5-r1 (both the automatic stuff and the manual test procedure I gave you)
Comment 9 Jeremy Murphy 2011-01-07 00:25:02 UTC
Created attachment 259105 [details]
t9200 test failure

OK, I re-emerged and it worked this time for some reason.  Here is the output of the t9200 test from the t directory.
Comment 10 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2011-01-07 07:09:56 UTC
You missed the --verbose --no-color options for running t9200 :-(.
It doesn't tell me where in the first t9200 subtest it failed.
Comment 11 Jeremy Murphy 2011-01-07 07:35:28 UTC
Created attachment 259114 [details]
t9200 test failure --verbose --no-color

Ah, sorry, by the time I got it working I forgot what I was doing.
Comment 12 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2011-01-07 08:26:07 UTC
Ok, reproduced now.
Specifically, with FEATURES=-userpriv USE=-cvs, the CVS code is still building, and the CVS tests are running. Only, CVS can NEVER be run as root, and that's why the tests are failing.

I'm working on a patch.

It's a false positive for your system, but one that should be fixed for future use anyway.
Comment 13 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2011-01-07 09:00:18 UTC
Fixed in 1.7.3.5-r1, no revbump.
Not closing this bug because I need to port it to 1.7.4 and submit to upstream.
Comment 14 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2011-01-07 20:50:00 UTC
Ported to 1.7.4_rc1, and send a version of the patch to the upstream mailing list.
Comment 15 Jeremy Murphy 2011-01-08 05:56:00 UTC
Thanks for devising a patch so quickly.  Any chance you could also apply it to 1.7.3.4-r1, since that is the latest stable version?
Comment 16 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2011-01-08 06:33:53 UTC
Done
Comment 17 Peter Stuge 2012-05-19 18:50:37 UTC
Created attachment 312295 [details, diff]
Updated patch against current git.git master HEAD

dev-vcs/git-9999 currently fails to build because of the old patch. I rebased the patch on top of current master.
Comment 18 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2012-05-20 04:25:08 UTC
(In reply to comment #17)
> Created attachment 312295 [details, diff] [details, diff]
> Updated patch against current git.git master HEAD
> 
> dev-vcs/git-9999 currently fails to build because of the old patch. I
> rebased the patch on top of current master.
This is in the tree now. In future, please open a new bug.