Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 349784

Summary: net-libs/nativebiginteger TFU ebuild
Product: Gentoo Linux Reporter: Diego Elio Pettenò (RETIRED) <flameeyes>
Component: New packagesAssignee: Thomas Sachau <tommy>
Severity: QA CC: c1pher, esigra, qa
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 129413, 331933    
Attachments: Diff from ebuild in tree
New patch for some magic assembly
as-needed fix
Improved assembly fix.

Description Diego Elio Pettenò (RETIRED) gentoo-dev 2010-12-26 15:29:27 UTC
Let's see..

 - on x86 it builds a TEXTREl object, filtering PIE; why at all?
 - it fails to properly account for ldflags;
 - it filters --as-needed rather than PASSING THE LIBRARIES IN THE CORRECT ORDER;

I'm tempted to kill it with fire, let's instead consider fixing it properly, shall we?
Comment 1 Dane Smith (RETIRED) gentoo-dev 2010-12-27 14:51:20 UTC
Created attachment 258174 [details]
Diff from ebuild in tree

Diff from the build in the tree. I tested this (with the patch to follow) on x86. _PLEASE_ test on amd64. I had I to use some assembly magic to make it play nice on x86. It should not affect the amd64 version, however, I don't trust any code I write.

New patch to follow.
Comment 2 Dane Smith (RETIRED) gentoo-dev 2010-12-27 14:52:51 UTC
Created attachment 258175 [details]
New patch for some magic assembly

My assembly is decent, but it's by no means the best. I'm fairly sure this fixes things. I know it compiles on x86. Hope it helps.
Comment 3 Dane Smith (RETIRED) gentoo-dev 2010-12-27 14:56:14 UTC
Created attachment 258177 [details]
as-needed fix

Pretty sure you already have this under control Tommy. But this will add the missing library into the mix.
Comment 4 Dane Smith (RETIRED) gentoo-dev 2010-12-27 15:01:15 UTC
Created attachment 258178 [details]
Improved assembly fix.

Changed #else to #elseif __i386__. Thanks for the catch Diego.
Comment 5 Thomas Sachau gentoo-dev 2010-12-28 12:35:27 UTC
Fixed with 0.6.4-r3