| Summary: | chromium slotted installation | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Mike Gilbert <floppym> |
| Component: | New packages | Assignee: | Chromium Project <chromium> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | nikoli |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
Alex's patch
floppym's new patch |
||
|
Description
Mike Gilbert
2010-12-24 02:42:07 UTC
Created attachment 257906 [details, diff]
Alex's patch
Created attachment 257907 [details, diff]
floppym's new patch
I took my original patch and incorporated some changes from wired's version. This new version also incorporates the chromium-launcher.sh change I proposed to make chromium-live --help work properly.
I'm not using the live ebuild, so feel free to commit when you think it's ready. (In reply to comment #2) > Created an attachment (id=257907) [details] Generally LGTM. A few comments: - it may be useful to have some variable for ${PN}${SUFFIX} - the non-live ebuilds should be as similar to 9999 as possible, and SUFFIX="-0" would look a it weird. Can we have an empty SUFFIX in that case? - does the new chromium-launcher.sh behave correctly when XDG_CONFIG_HOME contains spaces or other "special" characters? - obviously, make sure that the new chromium-launcher does not break old chromium versions. Ideally, we should use a separate file for the update. Closing this as fixed after wired's commit today. :) Now I need to come up with some other experimental feature to maintain in my overlay. |